Helm: use tpl to render the persistence secret
#603
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gerrit-K
requested review from
RussellSpitzer,
adutra,
ashvina,
collado-mike,
ebyhr,
eric-maynard,
flyrain,
jackye1995,
jbonofre,
snazy,
takidau and
vvcephei
as code owners
adutra
approved these changes
Jan 2, 2025
Contributor
|
Looks good to me. Please update the helm test cases to reflect this. |
Gerrit-K
force-pushed
the
helm-tpl-persistence-secret
branch
from
87be463 to
194917c
Compare
Contributor
Author
Thanks, good point! Added a test case for both, the deployment and the job Edit: I noticed the test failures and pushed another commit. They should be fixed now. |
Gerrit-K
force-pushed
the
helm-tpl-persistence-secret
branch
from
194917c to
37f4c22
Compare
Gerrit-K
force-pushed
the
helm-tpl-persistence-secret
branch
from
37f4c22 to
cb8a4c4
Compare
adutra
approved these changes
Jan 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using helm charts, it is recommended to use release-specific names in resources, e.g. via
{{ .Release.Name }}-prefix. If the persistence config secret is created along this release, it would be beneficial to allow using the templated name, e.g.instead of having to hardcode it like
This MR simply uses the
tpldirective to evaluate any template expressions in the value.