Fix startup failures in polaris-service distributions #593
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adutra
requested review from
RussellSpitzer,
ashvina,
collado-mike,
ebyhr,
eric-maynard,
flyrain,
jackye1995,
jbonofre,
snazy,
takidau and
vvcephei
as code owners
adutra
force-pushed
the
fix-service-distributions
branch
from
9224b58 to
52b19dc
Compare
adutra
force-pushed
the
fix-service-distributions
branch
from
52b19dc to
022a931
Compare
adutra
commented
Dec 27, 2024
| into(project.layout.buildDirectory.dir("docker-dist")) | ||
| from(startScripts) { into("bin") } | ||
| from(shadowJar) { into("lib") } | ||
| doFirst { delete(project.layout.buildDirectory.dir("regtest-dist")) } |
Contributor
Author
There was a problem hiding this comment.
I am not sure why this doFirst section was introduced. I do not see any "regtest-dist" directory in the codebase.
jbonofre
approved these changes
Dec 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #542.
The main issue was that the "main"
startScriptstask was configured for the shaded jar, but it shouldn't have: this task produces scripts suitable for the "main" distribution; the shadow jar plugin comes with its own task,startShadowScriptsthat produces scripts for the "shaded" distribution.I manually verified that both distributions contain the required jars, that both contain scripts called
polaris-service, and that the scripts work.This PR also switches the docker layout to "main" (exploded jars) instead of "shadow" (uber-jar). I manually verified that images built with this layout work.
Finally, this PR also fixes the fact that the shadow distribution was missing the LICENSE and NOTICE files.