-
Notifications
You must be signed in to change notification settings - Fork 332
Prefer RealmConfig fields #2971
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7c9319f to
8cebca8
Compare
minor cleanup of verbose code
8cebca8 to
cf5465d
Compare
dimas-b
approved these changes
Nov 4, 2025
Contributor
dimas-b
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice cleanup 👍 Thanks, @XN137 !
This change does not appear to alter any functional behavior. I propose to merge tomorrow.
snazy
approved these changes
Nov 4, 2025
Member
snazy
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice catch!
XN137
added a commit
to XN137/polaris
that referenced
this pull request
Nov 6, 2025
minor cleanup of verbose code
snazy
added a commit
to snazy/polaris
that referenced
this pull request
Nov 20, 2025
* fix typo in Ozone getting-started guide (apache#2975) * NoSQL: Persistence API (apache#2965) Provides the persistence API parts for the NoSQL persistence work. Most of this PR are purely interfaces and annotations. It consists of a low-level `Persistence` interface to read and write individual `Obj`ects and the corresponding pluggable `ObjType`s. The API module also contains upstream SPIs for database specific implementations and downstream APIs for atomic commits and indexes. Also some CDI specific infrastructure helper annotations. Unit tests cover the few pieces of actual executable code in this change. This change also adds a README, which references functionality and modules that are not in this PR, but already provide an overview of the overall interactions. * Handle poetry lock update (apache#2942) * Update dependency com.azure:azure-sdk-bom to v1.3.2 (apache#2979) * Added interface for reporting metrics (apache#2887) Co-authored-by: Alexandre Dutra <[email protected]> * Prefer RealmConfig fields (apache#2971) minor cleanup of verbose code * Update community meetings note links due to document split (apache#2981) * NoSQL: database agnostic implementation + in-memory backend (apache#2977) This change contains the database agnostic implementation plus the in-memory backend used for testing purposes, and a Junit extension. These three modules are difficult to put into isolated PRs. The "main implementation" contains the commit-logic, indexes-logic and the caching part. `PersistenceImplementation` is (more or less) a wrapper providing higher-level functionality backed by a database's `Backend` implementation. The latter provides the bare minimum functionality. Other implementations of the `Persistence` interface are just to transparently add caching and commit-attempt specific case. No call site needs to bother about the actual implementation and/or its layers. Tests in the `polaris-persistence-nosql-impl` module use the in-memory backend via the Junit extension. Common tests for all backends, in-memory in this PR and MongoDB in a follow-up, are in the testFixtures of the `polaris-persistence-nosql-impl`. * Fix incorrect column name in ModelEvent (apache#2987) Fixes apache#2913 * Rename request ID header (apache#2988) * Update dependency org.agrona:agrona to v2.3.1 (apache#2986) * Update actions/stale digest to fad0de8 (apache#2984) * Last merged commit 291bd7d --------- Co-authored-by: Dmitri Bourlatchkov <[email protected]> Co-authored-by: Yong Zheng <[email protected]> Co-authored-by: Mend Renovate <[email protected]> Co-authored-by: cccs-cat001 <[email protected]> Co-authored-by: Alexandre Dutra <[email protected]> Co-authored-by: Christopher Lambert <[email protected]> Co-authored-by: JB Onofré <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
minor cleanup of verbose code