Automate Helm tests with Gradle #2964

adutra · 2025-11-03T13:58:26Z

This PR automates Helm tests and make them executable as part of the Gradle build.

helm/polaris/README.md

helm/polaris/README.md.gotmpl

dimas-b

LGTM 👍

dimas-b · 2025-11-03T17:06:42Z

CONTRIBUTING.md

+  * [SDKMAN!](https://sdkman.io/) - Run `sdk list java` to see available distributions, then `sdk install java <identifier>` to install.
+  * [jEnv](https://www.jenv.be/) - You can also use jEnv to manage Java versions.
+
+* **Docker**: Required for integration tests and building container images.


nit: Docker or Podman? Podman with its docker compatibility shims works fairly well in my local build.

snazy

This is nice!

Some comments - all Gradle related improvements.

snazy · 2025-11-03T17:19:06Z

helm/polaris/build.gradle.kts

+description = "Apache Polaris (incubating) Helm Chart"
+
+val helmTestReportsDir = layout.buildDirectory.dir("reports")
+


Suggested change

val runtimeServerDistribution by configurations.registering {

isCanBeConsumed = true

isCanBeResolved = false

}

dependencies {

runtimeServerDistribution(project(":polaris-server", "distributionElements"))

}

helm/polaris/build.gradle.kts

snazy · 2025-11-03T17:26:34Z

helm/polaris/build.gradle.kts

+    workingDir = rootProject.projectDir
+
+    // Output: file containing SHA digest of built image
+    val outputFile = helmTestReportsDir.get().file("minikube-images.sha256")


Better relativize outputFile to project.projectDir (or better this.workingDir) here (and in other places) so the commandLine doesn't contain any local paths.

Within a task configuration block, you can

Suggested change

val outputFile = helmTestReportsDir.get().file("minikube-images.sha256")

val outputFile = helmTestReportsDir.get().file("minikube-images.sha256").relativeTo(project.projectDir)

snazy · 2025-11-03T17:27:06Z

helm/polaris/build.gradle.kts

+
+    dependsOn(":polaris-server:quarkusBuild")
+
+    inputs.dir(rootProject.file("runtime/server/build/quarkus-app"))


Use the approach from above.

snazy · 2025-11-03T17:44:49Z

helm/polaris/build.gradle.kts

+    group = "documentation"
+    description = "Generate Helm chart documentation using helm-docs"
+
+    workingDir = rootProject.projectDir


Suggested change

workingDir = rootProject.projectDir

snazy · 2025-11-03T17:46:35Z

helm/polaris/build.gradle.kts

+tasks.named("build") {
+  dependsOn(intTest)
+  dependsOn(helmDocs)
+}


Suggested change

tasks.named("build") {

dependsOn(intTest)

dependsOn(helmDocs)

}

tasks.named("assemble") { dependsOn(helmDocs) }

snazy · 2025-11-03T17:47:17Z

helm/polaris/README.md

+make install-dependencies-brew
+make install-optional-dependencies-brew


Mind adding this as a macOS variant but leave the Linux one?

(Also for the other occurrences below)

snazy · 2025-11-03T17:47:52Z

helm/polaris/build.gradle.kts

+    dependsOn(chartTestingInstall)
+  }
+
+tasks.named("check") { dependsOn(test) }


check is expected to exercise checks

Suggested change

tasks.named("check") { dependsOn(test) }

tasks.named("check") { dependsOn(test, intTest) }

So check is expected to run intTest? TIL :-)

snazy · 2025-11-03T17:51:40Z

.github/workflows/gradle.yml

          ./gradlew \
            intTest \
            -x :polaris-runtime-service:intTest \
+            -x :polaris-helm:intTest \


Suggested change

-x :polaris-helm:intTest \

-x :polaris-helm:check \

So check doesn't work, :polaris-helm:intTest still gets executed.

adutra · 2025-11-05T13:45:58Z

helm/polaris/build.gradle.kts

+
+    dependsOn(":polaris-server:quarkusBuild")
+
+    inputs.files(runtimeServerDistribution)


@snazy I think this is the only task that actually needs this configuration as input.

As for the Dockerfile, I don't see any other way to reference it as it is not an output of any task (that I know of). Should I create a configuration in polaris-server to expose it?

adutra · 2025-11-05T15:52:22Z

To all the reviewers: sorry for so pushing so many commits 😅 – it was harder than I thought to get this PR right.

Note: with this change, ./gradlew check or ./gradlew build would fail if the necessary tools are not installed (helm, ct, minikube...). I think that's fair but happy to discuss this if someone disagrees.

Automate Helm tests with Gradle

724fd32

This PR automates Helm tests and make them executable as part of the Gradle build.

github-project-automation bot added this to Basic Kanban Board Nov 3, 2025

github-project-automation bot moved this to PRs In Progress in Basic Kanban Board Nov 3, 2025

singhpk234 reviewed Nov 3, 2025

View reviewed changes

helm/polaris/README.md Outdated Show resolved Hide resolved

helm/polaris/README.md.gotmpl Outdated Show resolved Hide resolved

dimas-b previously approved these changes Nov 3, 2025

View reviewed changes

github-project-automation bot moved this from PRs In Progress to Ready to merge in Basic Kanban Board Nov 3, 2025

dimas-b requested a review from snazy November 3, 2025 17:08

snazy reviewed Nov 3, 2025

View reviewed changes

adutra dismissed dimas-b’s stale review via ceb43a8 November 5, 2025 13:42

adutra force-pushed the gradle-helm branch from 8d478b7 to ceb43a8 Compare November 5, 2025 13:42

adutra commented Nov 5, 2025

View reviewed changes

adutra force-pushed the gradle-helm branch 2 times, most recently from 9070130 to 1e4db2c Compare November 5, 2025 14:10

review

f7f9c73

adutra force-pushed the gradle-helm branch from 1e4db2c to f7f9c73 Compare November 5, 2025 14:12

adutra added 7 commits November 5, 2025 15:24

cleanup

bfbd4dd

print logs if error

c772899

check if helm-docs is installed

cebb81a

more checks

09e638e

some fixes

fffa903

remove checks (overkill)

024b3af

fix CI

50fae2f

fix CI

b17a897

adutra force-pushed the gradle-helm branch from 2b45480 to b17a897 Compare November 5, 2025 15:54

		description = "Apache Polaris (incubating) Helm Chart"

		val helmTestReportsDir = layout.buildDirectory.dir("reports")

+val runtimeServerDistribution by configurations.registering {
+  isCanBeConsumed = true
+  isCanBeResolved = false
+}
+dependencies {
+  runtimeServerDistribution(project(":polaris-server", "distributionElements"))
+}

	val outputFile = helmTestReportsDir.get().file("minikube-images.sha256")
	val outputFile = helmTestReportsDir.get().file("minikube-images.sha256").relativeTo(project.projectDir)


		dependsOn(":polaris-server:quarkusBuild")

		inputs.dir(rootProject.file("runtime/server/build/quarkus-app"))

		make install-dependencies-brew
		make install-optional-dependencies-brew

	tasks.named("check") { dependsOn(test) }
	tasks.named("check") { dependsOn(test, intTest) }


		dependsOn(":polaris-server:quarkusBuild")

		inputs.files(runtimeServerDistribution)

Automate Helm tests with Gradle #2964

Are you sure you want to change the base?

Automate Helm tests with Gradle #2964

Uh oh!

Conversation

adutra commented Nov 3, 2025

Uh oh!

Uh oh!

Uh oh!

dimas-b left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

snazy left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

adutra commented Nov 5, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants