-
Notifications
You must be signed in to change notification settings - Fork 330
Add blog content to separate blogs branch (#2774) #2926
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
dimas-b
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd prefer to do CI changes related to building the site from multiple branches (main / versioned-docs / blogs) first, then move existing blogs to the new branch.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd prefer to delete (irrelevant) doc files in a separate PR for the sake of clarity.
| linkTitle: Getting Started | ||
| type: docs | ||
| weight: 101 | ||
| title: Apache Polaris 1.0.1-incubating has been released! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is this changing when we just "move" blogs?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In fact, it should not be necessary to change existing blog files, I think. If the blogs branch is created from main, it should already have all the blog files.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Github messed up when it generates diffs. It's a new file, instead of changes.
|
Thanks for the feedback @dimas-b I understand the CI changes should come first. I notice the PR is showing some files as "modified" (with red/green changes) when they should just show as "deleted". These are files from the old versioned-docs content - I'm not sure why Git is showing them as modifications instead of clean deletions. The actual blog content I'm adding is just the site/content/blog folder. A few questions on next steps:
|
|
@ashishksdev : I commented on the issue: #2774 (comment) |
|
Thanks a lot for working on it, @ashishksdev ! As I mentioned here #2774 (comment), this PR is good as the first PR to add blog content to the new branch. |
|
Do we need directory structure |
| # | ||
| title: "Doris X Polaris: Building Unified Data Lakehouse with Iceberg REST Catalog - A Practical Guide" | ||
| date: 2025-09-15 | ||
| author: zy-kkk |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR alters git author associations for existing blogs. I believe this should be avoided.
| @@ -17,10 +17,15 @@ | |||
| # specific language governing permissions and limitations | |||
| # under the License. | |||
| # | |||
| linkTitle: 'Catalog API Spec' | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Another weird diffs. Should be just a new file.
|
Thanks for the feedback and discussion on this PR! After reviewing the concerns raised, I realize this PR has several issues:
I'm going to close this PR and propose a cleaner approach:
Questions before I proceed:
Please let me know if you have any suggestions or a different approach in mind. Happy to follow whatever works best! |
This PR adds the site/content/blog content to the blogs branch as requested in #2774.
Does this PR introduce any user-facing change?
No — this moves documentation content to the designated branch.
How was this patch tested?
The blog folder site/content/blog was copied from the upstream main branch and committed to this blogs branch. Folder structure was verified.
CHANGELOG.md
Not applicable