Skip to content

Conversation

@dimas-b
Copy link
Contributor

@dimas-b dimas-b commented Oct 21, 2025

Following up on #2672, add new --no-sts option to CLI to allow configuring stsUnavailable in AwsStorageConfigInfo

snazy
snazy previously approved these changes Oct 22, 2025
@github-project-automation github-project-automation bot moved this from PRs In Progress to Ready to merge in Basic Kanban Board Oct 22, 2025
singhpk234
singhpk234 previously approved these changes Oct 22, 2025
"(Only for S3) The STS endpoint to use when connecting to STS"
)
STS_UNAVAILABLE = (
"(Only for S3) Indicates that STS is not available"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"(Only for S3) Indicates that STS is not available"
"(Only for S3 compatible object stores) Indicates that STS is not available"

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It could be used with AWS too. How about (Only for S3) Indicates that Polaris should not use STS (e.g. if STS is not available)?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Message updated. PTAL.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

makes sense, thanks @dimas-b !

Following up on apache#2672, add new `--no-sts` option to CLI to allow
configuring `stsUnavailable` in `AwsStorageConfigInfo`
@dimas-b dimas-b dismissed stale reviews from singhpk234 and snazy via 720a7ae October 22, 2025 18:00
@dimas-b dimas-b merged commit 1e356ea into apache:main Oct 22, 2025
15 checks passed
@github-project-automation github-project-automation bot moved this from Ready to merge to Done in Basic Kanban Board Oct 22, 2025
@dimas-b dimas-b deleted the no-sts-cli branch October 22, 2025 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants