Use AccessConfigProvider.getAccessConfig in DefaultFileIOFactory #2852
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dimas-b
reviewed
Oct 21, 2025
Contributor
dimas-b
left a comment
dimas-b
left a comment
There was a problem hiding this comment.
Thanks for your contribution @CodingBangboo ! Some preliminary comments below.
runtime/service/src/main/java/org/apache/polaris/service/catalog/io/DefaultFileIOFactory.java
Show resolved
Hide resolved
dimas-b
reviewed
Oct 21, 2025
runtime/service/src/main/java/org/apache/polaris/service/catalog/io/DefaultFileIOFactory.java
Outdated
Show resolved
Hide resolved
dimas-b
reviewed
Oct 22, 2025
Contributor
dimas-b
left a comment
dimas-b
left a comment
There was a problem hiding this comment.
LGTM, please ping me again when the PR is "ready for review" :)
Contributor
Author
|
@dimas-b Thanks again! The PR is ready for review. |
dimas-b
approved these changes
Oct 22, 2025
Contributor
dimas-b
left a comment
dimas-b
left a comment
There was a problem hiding this comment.
LGTM 👍 CC: @XJDKC @XN137 @dennishuo @HonahX
github-project-automation
bot
moved this from PRs In Progress
to Ready to merge
in Basic Kanban Board
github-project-automation
bot
moved this from Ready to merge
to Done
in Basic Kanban Board
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
As a follow-up of #2736 (comment), we want to make
AccessConfigProvider.getAccessConfiga unified entry point for all call path that need vended credential. This PR replace the usage ofFileIOUtil.refreshAccessConfigwithAccessConfigProvider.getAccessConfigin DefaultFileIOFactory.Why are the changes needed?
Does this PR introduce any user-facing change?
How was this patch tested?
CHANGELOG.md