Client: fix integration testing #2700
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-project-automation
bot
moved this from PRs In Progress
to Ready to merge
in Basic Kanban Board
github-project-automation
bot
moved this from Ready to merge
to Done
in Basic Kanban Board
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is side effect of #1619. Current if we try to run the integration locally via
make client-integration-test, it will try to fetch the latest image from dockerhub. It appears the latest image has some issues. Also, if we try to run locally via./gradlew run, we will run into issue as well. For the local one, it is due tojvmArgsis fixed and not allowed appended when using./gradlew run. Thus, with default offalseforDROP_WITH_PURGE_ENABLED. the local integration test will always failed.To avoid this issue, I added
build-serveras pre-requisite before running the test (which is the current behavior of our github action) and remove the extra image build state asclient-integration-testwill build it automatically now.