Azure: Fix azure expires at prefix for the credentials refresh #2633
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dimas-b
reviewed
Sep 19, 2025
Contributor
dimas-b
left a comment
dimas-b
left a comment
There was a problem hiding this comment.
Thanks for catching this, @singhpk234 !
.../src/main/java/org/apache/polaris/core/storage/azure/AzureCredentialsStorageIntegration.java
Show resolved
Hide resolved
dimas-b
previously approved these changes
Sep 19, 2025
github-project-automation
bot
moved this from PRs In Progress
to Ready to merge
in Basic Kanban Board
dimas-b
reviewed
Sep 19, 2025
Contributor
dimas-b
left a comment
dimas-b
left a comment
There was a problem hiding this comment.
Could you also add a note to CHANGELOG.md?
Contributor
Author
|
ACK, seems like we haven't frozen the CHANGELOG for 1.1, i put a PR for this here will add the CHANGELOG for this bug fix on the unreleased section so we can use this in prep of 1.2. |
sfc-gh-prsingh
force-pushed
the
feature/fix-azure-expires-at
branch
from
2d3e463 to
a9e7d43
Compare
dimas-b
approved these changes
Sep 19, 2025
github-project-automation
bot
moved this from Ready to merge
to Done
in Basic Kanban Board
Contributor
Author
|
Thank you @dimas-b ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the change
For the credential refresh endpoint for the ADLS its expected the expiration time should be sent with the prefix of
AZURE_SAS_TOKEN_EXPIRES_AT_MS_PREFIXwhich presently Polaris doesn't sends as the course of that the CredentialProvider responsible for the refresh fails the assertion here https://github.com/apache/iceberg/blob/main/azure/src/main/java/org/apache/iceberg/azure/adlsv2/VendedAdlsCredentialProvider.java#L123and hence not making it usable.
P.S I think we should also use constants for iceberg SDK in the StorageAccessProperty, but this is an orthogonal discussion for now.
Testing
Add a small UT