-
Notifications
You must be signed in to change notification settings - Fork 332
chore(docs): reorganize getting-started section #2611
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(docs): reorganize getting-started section #2611
Conversation
dimas-b
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your efforts on improving docs, @binarycat0 !
I have a somewhat radical comment below... I hope you do not mind refactoring the guides further :)
site/content/in-dev/unreleased/getting-started/alternate-conf/_index.md
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
using-polaris.md still assumes AWS when it talks about creating a catalog 🤔
I'd propose to break the getting started docs like this:
- Installing Dependencies
- Deploying Polaris
- Local Deployment
- Cloud Providers
- AWS
- GCP
- Azure
- Creating a Catalog
- S3
- AWS
- MinIO
- GCS
- Azure
- S3
- Using the Polaris Catalog (refer to the catalog created in the previous section)
The MinIO and other guides may have to be re-written without references to docker compose, just show docker instructions for MinIO, plus POLARIS CLI for creating the catalog.
Granted it's going to be a bit more work, but I hope the end result will be more user-friendly and will be easier to extend to new environments. WDYT?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The "Cloud Providers" getting started scripts actually do create a catalog as well. So maybe we don't need a new section on that. If we want to make the changes more consise, we may be able to make a reference to the create-catalog.sh script instead from within using-polaris.md, which takes care of all catalog creation.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for valuable comments! I will try to cover all in this PR 👌
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dimas-b will it be acceptable If I create the structure in this PR and create an extra Issue to cover the remaining later? Maybe by other volunteer.
- Creating a Catalog
- S3
- AWS (TBD)
- MinIO (done)
- GCS (TBD)
- Azure (TBD)
- S3
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please check new version 🙏
dimas-b
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The new doc structure LGTM 👍 Thanks!
I think it would be nice to rework the MinIO guide a bit and populate catalog creation guides (you may need to refer to the example deployment scripts for each cloud technology).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This section header is "clickable" in the left-hand pane, but the "Getting Stated" section is not (#2551)... Could you fix that too? I guess it's related to having render: never in the latter... Why don't we add some text to it and render it like all the other sections?
This can be done later, of course.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, the reason because of render: never. I will fix it.
| weight: 300 | ||
| --- | ||
|
|
||
| TBD No newline at end of file |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Still TBD?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suppose the Defining a Catalog section from Using Polaris needs to move here (with minor changes for each specific cloud technology).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
updated
| weight: 100 | ||
| --- | ||
|
|
||
| TBD No newline at end of file |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's more or less the same as MinIO, but you need to provide region and roleArn, but do not provide endpoint.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
updated
| weight: 200 | ||
| --- | ||
|
|
||
| In this guide we walk through setting up a simple Polaris Server with local [MinIO](https://www.min.io/) storage. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My thinking was to just give instructions for "manual" setup in this guide (copy from the docker compose file) and may be link to the docker compose example at the end of the guide (with minimal text, just indicating that the docker compose file shows and end-to-end integration example for MinIO). WDYT?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we keep the current version? Using MinIO looks like not a standard path, so I would prefer to save it as is.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Without refactoring this page, the whole Getting Started reorg is not quite complete, IMHO... Still, I'd be ok with merging these doc changes "as is". I can probably make a follow-up PR from my side. I guess it's easier than going through GH comments 😅
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would appreciate it if you cover this part from your side 🙏
c70ada2 to
e84e46e
Compare
e84e46e to
8bda153
Compare
|
@binarycat0 : is this PR "ready for review" now? 🙂 |
dimas-b
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your work on this @binarycat0 ! From my POV this PR is good to merge with quick follow up (on my part) in mind.
If there are no objects from other reviewers, I'll merge and follow up later today.
|
Follow-up PR: #2652 |
|
Thanks everyone for active support and suggestions. I believe the documentation will be much convenient to use with this new structure for new comers. Also, I understand there are much more things to do. 🚀 |
Motivation:
The current structure of the getting-started section is somewhat inconvenient due to inconsistent menu ordering and section naming. For example,
Quickstartdoesn't reflect its actual content - it's essentially a Local Deployment guide. Additionally, right after theQuickstartsection, we have examples ofDeploying Polaris On Cloud Providers, followed immediately by aPolaris + MinIOusage example. Meanwhile, the important Using Polaris section is placed at the very end.Goal:
In this PR, I propose a minor reorganization of the
Getting Startedsection that will enable new users and contributors to learn the project documentation in a more natural and intuitive way.Old documentation view:
New documentation view: