Skip to content

Conversation

@binarycat0
Copy link
Contributor

@binarycat0 binarycat0 commented Sep 18, 2025

  • add docs/getting-started/deploying-polaris section
    • move docs/quickstart.md -> docs/getting-started/deploying-polaris/local-deploy.md
    • move docs/getting-started/deploying-polaris -> docs/getting-started/deploying-polaris/cloud-deploy
    • fix AWS typo in quickstart-deploy-azure.md, quickstart-deploy-gcp.md
  • add docs/getting-started/creating-a-catalog section sctructure
    • Creating a Catalog
      • S3
        • AWS (TBD)
        • MinIO (MinIO example)
      • GCS (TBD)
      • Azure (TBD)
  • add docs/managing-security section
    • move docs/access-control.md -> docs/managing-security/access-control.md
    • move docs/external-idp.md -> docs/managing-security/external-idp/_index.md
    • create keycloak-idp.md -> docs/managing-security/external-idp/keycloak-idp.md as _Keycloak IDP example
    • add ref to ./keycloak-idp.md to docs/managing-security/external-idp/_index.md

Motivation:

The current structure of the getting-started section is somewhat inconvenient due to inconsistent menu ordering and section naming. For example, Quickstart doesn't reflect its actual content - it's essentially a Local Deployment guide. Additionally, right after the Quickstart section, we have examples of Deploying Polaris On Cloud Providers, followed immediately by a Polaris + MinIO usage example. Meanwhile, the important Using Polaris section is placed at the very end.

Goal:

In this PR, I propose a minor reorganization of the Getting Started section that will enable new users and contributors to learn the project documentation in a more natural and intuitive way.

Old documentation view:

Screenshot 2025-09-18 at 17 28 31

New documentation view:

image

@github-project-automation github-project-automation bot moved this to PRs In Progress in Basic Kanban Board Sep 18, 2025
@binarycat0 binarycat0 marked this pull request as ready for review September 18, 2025 19:01
Copy link
Contributor

@dimas-b dimas-b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your efforts on improving docs, @binarycat0 !

I have a somewhat radical comment below... I hope you do not mind refactoring the guides further :)

Copy link
Contributor

@dimas-b dimas-b Sep 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

using-polaris.md still assumes AWS when it talks about creating a catalog 🤔

I'd propose to break the getting started docs like this:

  • Installing Dependencies
  • Deploying Polaris
    • Local Deployment
    • Cloud Providers
      • AWS
      • GCP
      • Azure
  • Creating a Catalog
    • S3
      • AWS
      • MinIO
    • GCS
    • Azure
  • Using the Polaris Catalog (refer to the catalog created in the previous section)

The MinIO and other guides may have to be re-written without references to docker compose, just show docker instructions for MinIO, plus POLARIS CLI for creating the catalog.

Granted it's going to be a bit more work, but I hope the end result will be more user-friendly and will be easier to extend to new environments. WDYT?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The "Cloud Providers" getting started scripts actually do create a catalog as well. So maybe we don't need a new section on that. If we want to make the changes more consise, we may be able to make a reference to the create-catalog.sh script instead from within using-polaris.md, which takes care of all catalog creation.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for valuable comments! I will try to cover all in this PR 👌

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dimas-b will it be acceptable If I create the structure in this PR and create an extra Issue to cover the remaining later? Maybe by other volunteer.

  • Creating a Catalog
    • S3
      • AWS (TBD)
      • MinIO (done)
    • GCS (TBD)
    • Azure (TBD)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please check new version 🙏

@binarycat0 binarycat0 marked this pull request as draft September 19, 2025 10:22
@binarycat0 binarycat0 marked this pull request as ready for review September 19, 2025 13:39
Copy link
Contributor

@dimas-b dimas-b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The new doc structure LGTM 👍 Thanks!

I think it would be nice to rework the MinIO guide a bit and populate catalog creation guides (you may need to refer to the example deployment scripts for each cloud technology).

Copy link
Contributor

@dimas-b dimas-b Sep 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This section header is "clickable" in the left-hand pane, but the "Getting Stated" section is not (#2551)... Could you fix that too? I guess it's related to having render: never in the latter... Why don't we add some text to it and render it like all the other sections?

This can be done later, of course.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, the reason because of render: never. I will fix it.

weight: 300
---

TBD No newline at end of file
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still TBD?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suppose the Defining a Catalog section from Using Polaris needs to move here (with minor changes for each specific cloud technology).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated

weight: 100
---

TBD No newline at end of file
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's more or less the same as MinIO, but you need to provide region and roleArn, but do not provide endpoint.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated

weight: 200
---

In this guide we walk through setting up a simple Polaris Server with local [MinIO](https://www.min.io/) storage.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My thinking was to just give instructions for "manual" setup in this guide (copy from the docker compose file) and may be link to the docker compose example at the end of the guide (with minimal text, just indicating that the docker compose file shows and end-to-end integration example for MinIO). WDYT?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we keep the current version? Using MinIO looks like not a standard path, so I would prefer to save it as is.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Without refactoring this page, the whole Getting Started reorg is not quite complete, IMHO... Still, I'd be ok with merging these doc changes "as is". I can probably make a follow-up PR from my side. I guess it's easier than going through GH comments 😅

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would appreciate it if you cover this part from your side 🙏

@binarycat0 binarycat0 marked this pull request as draft September 22, 2025 15:09
@binarycat0 binarycat0 force-pushed the chore/docs/reorganize-getting-started branch from c70ada2 to e84e46e Compare September 22, 2025 15:29
@binarycat0 binarycat0 force-pushed the chore/docs/reorganize-getting-started branch from e84e46e to 8bda153 Compare September 22, 2025 15:34
@dimas-b
Copy link
Contributor

dimas-b commented Sep 22, 2025

@binarycat0 : is this PR "ready for review" now? 🙂

@binarycat0 binarycat0 marked this pull request as ready for review September 22, 2025 18:56
Copy link
Contributor

@dimas-b dimas-b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your work on this @binarycat0 ! From my POV this PR is good to merge with quick follow up (on my part) in mind.

If there are no objects from other reviewers, I'll merge and follow up later today.

@github-project-automation github-project-automation bot moved this from PRs In Progress to Ready to merge in Basic Kanban Board Sep 22, 2025
@dimas-b dimas-b merged commit eb7618b into apache:main Sep 22, 2025
14 checks passed
@github-project-automation github-project-automation bot moved this from Ready to merge to Done in Basic Kanban Board Sep 22, 2025
@dimas-b
Copy link
Contributor

dimas-b commented Sep 22, 2025

Follow-up PR: #2652

@binarycat0
Copy link
Contributor Author

Thanks everyone for active support and suggestions. I believe the documentation will be much convenient to use with this new structure for new comers. Also, I understand there are much more things to do. 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants