Clarify the purpose of REPLACE_NEW_LOCATION_PREFIX_WITH_CATALOG_DEFAULT_KEY #2509
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
The test failure is not related. |
Contributor
|
These tests are fixed by #2511, let's rebase after the fix merges. |
github-project-automation
bot
moved this from PRs In Progress
to Done
in Basic Kanban Board
github-project-automation
bot
moved this from Done
to PRs In Progress
in Basic Kanban Board
eric-maynard
approved these changes
Sep 8, 2025
github-project-automation
bot
moved this from PRs In Progress
to Ready to merge
in Basic Kanban Board
github-project-automation
bot
moved this from Ready to merge
to Done
in Basic Kanban Board
snazy
added a commit
to snazy/polaris
that referenced
this pull request
Nov 20, 2025
* Update dependency io.netty:netty-codec-http2 to v4.2.6.Final (apache#2520) * Update dependency org.testcontainers:localstack to v1.21.3 (apache#2497) * Allow overriding createCatalog calls in integrations tests (apache#2516) This is mostly to add testing flexibility in downstream projects. * Allow `PolarisServerManager` implementations to define custom client headers (apache#2510) `PolarisServerManager` is a plugin point for downstream builds to define runtime env. for tests under `integration-tests`. This change allows more flexibility for test runtime environments by allowing injecting extra headers into test clients. * Fix deprecation warnings around RandomStringUtils (apache#2507) the `RandomStringUtils.random` method is deprecated since commons-lang 3.17.0 apache/commons-lang@69cb996 * Add support for poetry build with wheel (apache#2425) * Core: Clarify the purpose of REPLACE_NEW_LOCATION_PREFIX_WITH_CATALOG_DEFAULT_KEY (apache#2509) * Update gradle/actions digest to ed40850 (apache#2524) * Update dependency com.fasterxml.jackson:jackson-bom to v2.20.0 (apache#2470) * Update hadoop to v3.4.2 (apache#2466) * Last merged commit a1d1176 --------- Co-authored-by: Mend Renovate <[email protected]> Co-authored-by: Dmitri Bourlatchkov <[email protected]> Co-authored-by: Christopher Lambert <[email protected]> Co-authored-by: Yong Zheng <[email protected]> Co-authored-by: Yufei Gu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The catalog property REPLACE_NEW_LOCATION_PREFIX_WITH_CATALOG_DEFAULT_KEY was introduced for test only. It causes confusion like this, #2473 (comment). This PR is to clarify it. We should figure out a way to remove the logic from the non-test code later.