Skip to content

Fix CI #2489

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 2, 2025
Merged

Fix CI #2489

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9c4c4fb
Use local diagnostics in TransactionWorkspaceMetaStoreManager
dimas-b Sep 2, 2025
62fd0e9
Add resetCredentials to PolarisPrincipalsEventServiceDelegator
dimas-b Sep 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions ...c/main/java/org/apache/polaris/core/persistence/TransactionWorkspaceMetaStoreManager.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -184,9 +184,7 @@ public PrincipalSecretsResult resetPrincipalSecrets(
long principalId,
@Nonnull String resolvedClientId,
String customClientSecret) {
callCtx
.getDiagServices()
.fail("illegal_method_in_transaction_workspace", "resetPrincipalSecrets");
diagnostics.fail("illegal_method_in_transaction_workspace", "resetPrincipalSecrets");
return null;
}

Expand Down
11 changes: 11 additions & 0 deletions ...rc/main/java/org/apache/polaris/service/admin/PolarisPrincipalsEventServiceDelegator.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,7 @@
import jakarta.ws.rs.core.SecurityContext;
import org.apache.polaris.core.admin.model.CreatePrincipalRequest;
import org.apache.polaris.core.admin.model.GrantPrincipalRoleRequest;
import org.apache.polaris.core.admin.model.ResetPrincipalRequest;
import org.apache.polaris.core.admin.model.UpdatePrincipalRequest;
import org.apache.polaris.core.context.RealmContext;
import org.apache.polaris.service.admin.api.PolarisPrincipalsApiService;
Expand All @@ -43,6 +44,16 @@ public Response createPrincipal(
return delegate.createPrincipal(request, realmContext, securityContext);
}

@Override
public Response resetCredentials(
String principalName,
ResetPrincipalRequest resetPrincipalRequest,
RealmContext realmContext,
SecurityContext securityContext) {
return delegate.resetCredentials(
principalName, resetPrincipalRequest, realmContext, securityContext);
}

@Override
public Response deletePrincipal(
String principalName, RealmContext realmContext, SecurityContext securityContext) {
Expand Down