Remove PolarisCallContext.getDiagServices #2415
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
XN137
force-pushed
the
Remove-PolarisCallContext.getDiagServices
branch
from
a35657f to
d0086af
Compare
XN137
commented
Aug 26, 2025
| private PolarisDiagnostics diagnostics = new PolarisDefaultDiagServiceImpl(); | ||
| @Mock private CallContext callContext; | ||
| @Mock private PolarisCallContext polarisCallContext; | ||
| @Mock private PolarisDiagnostics polarisDiagnostics; |
Contributor
Author
There was a problem hiding this comment.
note that this mock would have been silently ignoring any diagnostics errors
adutra
previously approved these changes
Aug 26, 2025
github-project-automation
bot
moved this from PRs In Progress
to Ready to merge
in Basic Kanban Board
dimas-b
previously approved these changes
Aug 26, 2025
XN137
force-pushed
the
Remove-PolarisCallContext.getDiagServices
branch
from
d0086af to
973fb62
Compare
XN137
force-pushed
the
Remove-PolarisCallContext.getDiagServices
branch
from
973fb62 to
a9cff35
Compare
Contributor
Author
|
rebased after trivial merge conflicts in multiple files (they auto-resolved locally) |
XN137
force-pushed
the
Remove-PolarisCallContext.getDiagServices
branch
from
a9cff35 to
f471f8a
Compare
adutra
approved these changes
Sep 1, 2025
dimas-b
approved these changes
Sep 2, 2025
github-project-automation
bot
moved this from Ready to merge
to Done
in Basic Kanban Board
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PolarisDiagnosticsis application-scoped and not scoped to any realm or request.thus we should inject it at object construction time and not pass it along everywhere with
PolarisCallContext.this works towards less dependency on
PolarisCallContextand its eventual removal.