Remove generated Python client from git tracking #1810
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eric-maynard
requested review from
HonahX,
MonkeyCanCode,
RussellSpitzer,
adutra,
ajantha-bhat,
ashvina,
collado-mike,
dennishuo,
dimas-b,
ebyhr,
flyrain,
jackye1995,
jbonofre,
pingtimeout,
singhpk234,
snazy,
takidau and
vvcephei
as code owners
HonahX
reviewed
Jun 5, 2025
Contributor
HonahX
left a comment
HonahX
left a comment
There was a problem hiding this comment.
Overall LGTM! Just one comment about installation experience
| @@ -30,14 +30,17 @@ for arg in "$@"; do | |||
| fi | |||
| done | |||
|
|
|||
| # Check if the python client needs regeneration | |||
| if [ "$repair" == true ] || [ ! -f "${dir}/client/python/polaris/catalog/__init__.py" ]; then | |||
| ./gradlew regeneratePythonClient | |||
Contributor
There was a problem hiding this comment.
The generation will likely fails if user use MacOS, due to the .DS_Store file thing : (.
This is not our fault, but to ensure a smoother installation experiences, shall we consider cleaning the folder before regenerating here or add .DS_Store, poetry.lock to the EXCLUDE_PATHS/EXCLUDE_EXTENSION in the regenerate.sh?
Contributor
|
We may also need to update the Spark Getting-Started example's Dockerfile to run the polaris/getting-started/spark/notebooks/Dockerfile Lines 24 to 30 in 1655dae |
Contributor
Author
eric-maynard
force-pushed
the
ignore-python-client
branch
from
01c4513 to
1e3a4fe
Compare
sfc-gh-jojiang
approved these changes
Jun 11, 2025
sfc-gh-jojiang
left a comment
sfc-gh-jojiang
left a comment
There was a problem hiding this comment.
LGTM! Thanks for removing and updating the getting-started examples. I think we can also move the auto-generated doc and test too, probably in a follow-up PR.
HonahX
approved these changes
Jun 11, 2025
github-project-automation
bot
moved this from PRs In Progress
to Ready to merge
in Basic Kanban Board
github-project-automation
bot
moved this from Ready to merge
to Done
in Basic Kanban Board
snazy
added a commit
to snazy/polaris
that referenced
this pull request
Nov 20, 2025
* main: Update dependency io.projectreactor.netty:reactor-netty-http to v1.2.7 (apache#1845) * docs: fix broken 'Polaris Overview' link in README.md (apache#1846) docs: fix broken 'Polaris Overview' link in README.md Co-authored-by: Joy Haldar <[email protected]> * Update spark client license (apache#1839) * Update LICENCE (apache#1851) * Add Yun Zou as the new committer Co-authored-by: Yufei Gu <yufei.apache.org> * main: Update docker.io/jaegertracing/all-in-one Docker tag to v1.70.0 (apache#1853) * main: Update dependency io.opentelemetry.semconv:opentelemetry-semconv to v1.34.0 (apache#1850) * main: Update dependency boto3 to v1.38.34 (apache#1852) * main: Update dependency org.postgresql:postgresql to v42.7.7 (apache#1859) * [SPEC] Add base-location keyword for GenericTable API (apache#1543) * Update LICENSE for binary distributions (apache#1855) * Add integration tests to Python Client (apache#1856) * Update JDBC Getting-started example's README.md to use localhost for curl commands (apache#1872) * Remove PolarisConfiguration.loadConfig (v2) (apache#1858) * Enhance EclipseLink quickstart (apache#1870) 1. Update the name catalog name used to `quickstart_catalog` from `polaris` to make it consistent 2. Update the name of `eclipselink-trino-1` to `polaris-trino-1` 3. make the polaris server url consistent with using `localhost` to avoid failures * Remove generated Python client from git tracking (apache#1810) After apache#1675, we now generate the Python client on-demand when it's needed by tests or the CLI. With this, we can safely remove the Python client from being tracked in the repo and add its files to .gitignore * Fix telemetry quickstart example for 1.0 release (apache#1873) * main: Update gradle/actions digest to ac638b0 (apache#1877) * main: Update dependency boto3 to v1.38.35 (apache#1874) * Removing star import and adding errorprone rule (apache#1831) Fixes apache#1100 * NoSQL: merge related changes * Last merged commit 0faf948 --------- Co-authored-by: Mend Renovate <[email protected]> Co-authored-by: Joy Haldar <[email protected]> Co-authored-by: Joy Haldar <[email protected]> Co-authored-by: gh-yzou <[email protected]> Co-authored-by: Yufei Gu <[email protected]> Co-authored-by: Yun Zou <[email protected]> Co-authored-by: Honah (Jonas) J. <[email protected]> Co-authored-by: Eric Maynard <[email protected]> Co-authored-by: William Hyun <[email protected]> Co-authored-by: gfakbar20 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After #1675, we now generate the Python client on-demand when it's needed by tests or the CLI. With this, we can safely remove the Python client from being tracked in the repo and add its files to .gitignore
Fixes #755