Skip to content

Add unit test for legacy config lookup #1774

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 2, 2025
Merged

Add unit test for legacy config lookup #1774

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
38 changes: 38 additions & 0 deletions ...-core/src/test/java/org/apache/polaris/service/storage/PolarisConfigurationStoreTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,12 +20,15 @@

import jakarta.annotation.Nullable;
import java.util.List;
import java.util.Map;
import java.util.function.Function;
import java.util.function.Supplier;
import org.apache.polaris.core.PolarisCallContext;
import org.apache.polaris.core.config.BehaviorChangeConfiguration;
import org.apache.polaris.core.config.FeatureConfiguration;
import org.apache.polaris.core.config.PolarisConfiguration;
import org.apache.polaris.core.config.PolarisConfigurationStore;
import org.apache.polaris.core.entity.CatalogEntity;
import org.junit.jupiter.api.Assertions;
import org.junit.jupiter.api.Test;
import org.mockito.Mockito;
Expand Down Expand Up @@ -144,4 +147,39 @@ public void testBehaviorAndFeatureConfigs() {

consumer.consumeConfiguration(featureConfig, () -> 42, 43);
}

@Test
public void testEntityOverrides() {
@SuppressWarnings("deprecation")
Function<Integer, FeatureConfiguration<String>> cfg =
i ->
PolarisConfiguration.<String>builder()
.key("key" + i)
.catalogConfig("polaris.config.catalog-key" + i)
.catalogConfigUnsafe("legacy-key" + i)
.description("")
.defaultValue("test-default" + i)
.buildFeatureConfiguration();

PolarisConfigurationStore store =
new PolarisConfigurationStore() {
@Override
public <T> @Nullable T getConfiguration(PolarisCallContext ctx, String configName) {
//noinspection unchecked
return (T) Map.of("key2", "config-value2").get(configName);
}
};

PolarisCallContext ctx = null;
CatalogEntity entity =
new CatalogEntity.Builder()
.addProperty("polaris.config.catalog-key3", "entity-new3")
.addProperty("legacy-key4", "entity-legacy4")
.build();

Assertions.assertEquals("test-default1", store.getConfiguration(ctx, entity, cfg.apply(1)));
Assertions.assertEquals("config-value2", store.getConfiguration(ctx, entity, cfg.apply(2)));
Assertions.assertEquals("entity-new3", store.getConfiguration(ctx, entity, cfg.apply(3)));
Assertions.assertEquals("entity-legacy4", store.getConfiguration(ctx, entity, cfg.apply(4)));
}
}
Loading