Use canonical catalog property names in tests #1766
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* In `PolarisPolicyServiceIntegrationTest` * In `PolarisRestCatalogIntegrationTest` Following up to apache#1557
dimas-b
requested review from
MonkeyCanCode,
RussellSpitzer,
adutra,
ajantha-bhat,
ashvina,
collado-mike,
dennishuo,
ebyhr,
eric-maynard,
flyrain,
jackye1995,
jbonofre,
snazy,
takidau and
vvcephei
as code owners
adutra
approved these changes
May 31, 2025
github-project-automation
bot
moved this from PRs In Progress
to Ready to merge
in Basic Kanban Board
flyrain
approved these changes
Jun 1, 2025
github-project-automation
bot
moved this from Ready to merge
to Done
in Basic Kanban Board
github-project-automation
bot
moved this from Done
to PRs In Progress
in Basic Kanban Board
Contributor
|
reopen to trigger the CI, the hugo site CI still failed randomly, #1750 |
Contributor
Author
github-project-automation
bot
moved this from PRs In Progress
to Done
in Basic Kanban Board
eric-maynard
reviewed
Jun 2, 2025
| private static final String[] DEFAULT_CATALOG_PROPERTIES = { | ||
| "allow.unstructured.table.location", "true", | ||
| "allow.external.table.location", "true" | ||
| "polaris.config.allow.unstructured.table.location", "true", |
Contributor
There was a problem hiding this comment.
Just a note that tests were intentionally left using the old properties, to make sure they keep working in light of the introduction of the new properties. Now that they passed for a while though, I think it's okay to migrate the tests over.
dimas-b
added a commit
to dimas-b/polaris
that referenced
this pull request
Jun 2, 2025
Following up on apache#1766
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PolarisPolicyServiceIntegrationTestPolarisRestCatalogIntegrationTestFollowing up to #1557