Updated name in ascii banner #1654
Conversation
scottteal
requested review from
HonahX,
MonkeyCanCode,
RussellSpitzer,
ajantha-bhat,
collado-mike,
dimas-b,
ebyhr,
eric-maynard,
flyrain,
jackye1995,
jbonofre,
pingtimeout,
singhpk234,
snazy,
takidau and
vvcephei
as code owners
github-project-automation
bot
moved this from PRs In Progress
to Ready to merge
in Basic Kanban Board
|
I am not sure we can say Apache yet without incubating? Probably not a big deal. |
|
We can for the banner/logo |
snazy
left a comment
snazy
left a comment
There was a problem hiding this comment.
Should we maybe let the whole community decide?
Maybe with 2 or 3 alternatives, where everybody has an equal +1/0/-1 choice?
quarkus/admin/src/main/resources/org/apache/polaris/admintool/banner.txt
Outdated
Show resolved
Hide resolved
dimas-b
left a comment
dimas-b
left a comment
There was a problem hiding this comment.
Thanks, @scottteal ! I like the new ascii art 🙂
| @@@@ | ||
| @@@ | ||
| @@ | ||
|
|
There was a problem hiding this comment.
nit: remove the trailing new line. Quarkus adds Powered by Quarkus 3.21.4 (right-justified) automatically. I think it'll look better without the extra empty line.
|
Having alternatives SGTM. I'll open one from my side presently. |
Contributes to apache#1653 Alternative to apache#1654
|
Alternative : #1655 Shall we wait a couple of days for other entries? |
Sure no problem as long we get a few :) I would never want to squash someone's artistic drive. How about we wait till 5/28 and link all alternatives in the parent issue #1653 and we can do approval voting with emojis. I would end the vote on Friday 5/30 and merge the winner. I don't think it's super serious since we could even change the banner every release if we wanted to. That would be kinda fun as well |
github-project-automation
bot
moved this from Ready to merge
to Done
in Basic Kanban Board
6 participants
Issue: #1653
Dev List: https://lists.apache.org/thread/bdv588pdn361852oj1cm81govl75m51h
Updating the ASCII banner art to reflect the project's name "Apache Polaris"