[Policy Store] Add policyTypeCode to Slice/Index for Future Filtering Support and Update Policy Persistence Method #1628
Conversation
HonahX
changed the title
HonahX
changed the title
HonahX
requested review from
MonkeyCanCode,
RussellSpitzer,
adutra,
ashvina,
collado-mike,
dennishuo,
dimas-b,
ebyhr,
eric-maynard,
flyrain,
jackye1995,
jbonofre,
pingtimeout,
singhpk234,
snazy,
takidau and
vvcephei
as code owners
There was a problem hiding this comment.
I'm not sure it's worth bothering with EclipseLink support for new features since EclipseLink is deprecated.
There was a problem hiding this comment.
I'm OK with either way. Adding it to EclipseLink is nice to have.
There was a problem hiding this comment.
Since policy support is already available in EclipseLink and this PR introduces only a minor change ahead of the 1.0 release, I think it's reasonable to include it. My understanding is that we don’t plan to add any major new features to EclipseLink moving forward.
There was a problem hiding this comment.
Not a blocker: I feel like these two classes are interchangeable in Polaris. Can we merge them to avoid any type mismatching like this? cc @dennishuo
github-project-automation
bot
moved this from PRs In Progress
to Ready to merge
in Basic Kanban Board
|
Please rebase to get the latest CI changes |
HonahX
force-pushed
the
honahx_load_all_targets_on_policy_refactor
branch
from
4395fbb to
dc12b13
Compare
| default void deleteAllEntityPolicyMappingRecordsInCurrentTxn( | ||
| @Nonnull PolarisCallContext callCtx, | ||
| @Nonnull PolarisEntityCore entity, | ||
| @Nonnull PolarisBaseEntity entity, |
There was a problem hiding this comment.
side note: we should probably review the PolarisEntityCore type hierarchy. PolarisBaseEntity dominates all child types, so it can probably be folded into PolarisEntityCore (or the other way around).
...c/src/main/java/org/apache/polaris/extension/persistence/relational/jdbc/QueryGenerator.java
Outdated
Show resolved
Hide resolved
github-project-automation
bot
moved this from Ready to merge
to Done
in Basic Kanban Board
4 participants
This PR adds
policyTypeCodeto both the in-memory tree map store's slice and the SQL tablepolicy_mapping_recordsindex (JDBC has already included this in #1468 ). This change lays the groundwork for future features that require efficient filtering by policy type—such as fetching all entities with a data compaction policy attached.As part of this update, the signature of
loadAllTargetsOnPolicyis also modified to acceptpolicyTypeCode, allowing the method to take advantage of the new index for improved performance.cc: @flyrain @singhpk234