fix(quickstart): fixed quickstart jdbc to include client id and secrets (#1613) #1614
Conversation
pjanuario
requested review from
adutra,
ashvina,
dennishuo,
dimas-b,
eric-maynard and
jackye1995
as code owners
pjanuario
requested review from
HonahX,
MonkeyCanCode,
RussellSpitzer,
collado-mike,
ebyhr,
flyrain,
jbonofre,
pingtimeout,
singhpk234,
snazy,
takidau and
vvcephei
as code owners
dimas-b
left a comment
dimas-b
left a comment
There was a problem hiding this comment.
Thanks for your contribution, @pjanuario ! I stated a comment thread below trying to better understand the problem :)
| export QUARKUS_DATASOURCE_USERNAME=postgres | ||
| export QUARKUS_DATASOURCE_PASSWORD=postgres | ||
| export CLIENT_ID=root | ||
| export CLIENT_SECRET=s3cr3t |
There was a problem hiding this comment.
Could you give some more details about why this is necessary?
There was a problem hiding this comment.
The secret comes from getting-started/jdbc/docker-compose-bootstrap-db.yml (added under #1470).
Having this value set up front creates a backwards logical dependency, IMHO 🤔
Since docker-compose-postgres.yml depends on the root secret and takes it from the user's env., I think docker-compose-bootstrap-db.yml should take the root secret from the user's env. too (and fail if it is not provided).
There was a problem hiding this comment.
+1, the spark client here passed creds here, can you please share what your command is to start docker
There was a problem hiding this comment.
I am starting with the product and I might be doing something wrong, but as new user I followed this jdbc tutorial as starting point and if we follow it, the service polaris-setup invokes the polaris/create_catalog.sh script that requires this secrets to be passed in order to create quickstart catalog.
This will fail because it doesnt have credentials, the log entries are i mentioned in #1613 .
There was a problem hiding this comment.
@pjanuario : You initial fix works fine. I'm just suggesting to improve it :)
|
#1610 seems to offer a more holistic fix for the same problem. |
|
Closing this in favour of #1646 |
github-project-automation
bot
moved this from PRs In Progress
to Done
in Basic Kanban Board
3 participants
While following the quickstart for jdbc the instructions are incomplete, this change adds missing env variables so that your can follow the instructions to launch a jdbc connected instance.