Remove FILE from default SUPPORTED_CATALOG_STORAGE_TYPES

[eric-maynard]

FILE has been included in the default value for SUPPORTED_CATALOG_STORAGE_TYPES since the config's inception, but we should consider removing it as users who don't read through configuring-polaris-for-production.md might be inadvertently leaving an insecure storage type enabled.

[snazy]

This is what #1532 already does - there's no need for a 2nd PR for the same thing.

[eric-maynard]

#1532 does a lot more than this. See this comment on that PR.

[dimas-b]

This PR makes sense to me end-to-end.

I agree that it conflicts with #1532 is some areas, but at it stands this PR appears to be self-sufficient, consistent and offers net improvement for user experience (removes defaults that users should not use anyway).

I would not mind merging this PR and rebasing #1532 since the latter has a bigger scope of changes and has some comment threads that need to be resolved.

@snazy WDYT?

[adnanhemani]

Overall, agreed with this change as well. One question - I know we've modified the integration tests, have we confirmed when running them that they continue to work?

[eric-maynard]

@snazy can you clarify if there is a technical reason for the -1 here?

[snazy]

Sure, #1532 has to go in first.

[snazy]

And this one duplicates work from #1532

[eric-maynard]

Why does #1532 have to go in first? It seems like 1532 subsumes this PR but they should merge quite neatly.

…

On Tue, May 20, 2025 at 6:04 PM Robert Stupp ***@***.***> wrote: *snazy* left a comment (apache/polaris#1566) <#1566 (comment)> And this one duplicates work from #1532 <#1532> — Reply to this email directly, view it on GitHub <#1566 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AFRE3SGBTQ7CE5F5R5Q5ACT27NOBZAVCNFSM6AAAAAB43T76IKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDQOJVGIYTSNJUGU> . You are receiving this because you authored the thread.Message ID: ***@***.***>