Document the Concept of realm Issue #1326: update doc based on public comments #1531
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Document the Concept of realm Issue apache#1326: updating based on PR comments
fabio-rizzo-01
requested review from
MonkeyCanCode,
RussellSpitzer,
adutra,
ashvina,
collado-mike,
dennishuo,
dimas-b,
ebyhr,
eric-maynard,
flyrain,
jackye1995,
jbonofre,
snazy,
takidau and
vvcephei
as code owners
Contributor
Author
Contributor
|
@fabio-rizzo-01 : normally it is not necessary to re-create PRs. You should be able to force-push into your own branch in your fork :) |
Contributor
|
@fabio-rizzo-01 : please try force-pushing commit a3c940f into your branch and re-opening the original PR, so that it's easier for reviewers to correlate text changes with previous comments. |
Contributor
Author
That didn't work, i'm still pushing to the same branch as you can see from the PR but the other PR still shows zero changes so github closed it |
Contributor
|
Closing to reopen #1478 |
github-project-automation
bot
moved this from PRs In Progress
to Done
in Basic Kanban Board
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.