Skip to content

Add missing postgres driver in getting-started #1441

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Add missing postgres driver in getting-started #1441

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions getting-started/eclipselink/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,7 @@ This example requires `jq` to be installed on your machine.
:polaris-quarkus-server:quarkusAppPartsBuild --rerun \
:polaris-quarkus-admin:assemble \
:polaris-quarkus-admin:quarkusAppPartsBuild --rerun \
-PeclipseLinkDeps=org.postgresql:postgresql:42.7.5 \
Copy link
Contributor

@flyrain flyrain Apr 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was removed by #1411. After #1411, the driver should be pulled by the default build. Do we need to add it here? cc @jbonofre

Copy link
Member

@jbonofre jbonofre Apr 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with @flyrain : PostgreSQL JDBC driver is now embedded by default. So, no need to add it.

Copy link
Contributor

@flyrain flyrain Apr 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the problem would be gradle doesn't package the runtimeonly dependencies. We may add a task like this.

tasks.register('copyRuntimeLibs', Copy) {
    from configurations.runtimeClasspath
    into "$buildDir/libs/runtime"
}

Copy link
Contributor

@flyrain flyrain Apr 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The postgres was added as a runtimeOnly dep: https://github.com/polaris-catalog/polaris/blob/1c684d2378e923ba410f38c1c79f12130db33f94/quarkus/server/build.gradle.kts#L52-L52

Copy link
Member

@jbonofre jbonofre Apr 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup, good catch. It's enough for the "distributions" (I checked on the 0.10.0-beta-incubating release, and PostgreSQL driver is included in the distribution). But probably need extra for "started guide" packages.

Copy link
Contributor Author

@pingtimeout pingtimeout Apr 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oooooh that's a nasty one. @jbonofre I can confirm that the polaris image is fine and has the postgres driver. However the polaris-admin-tool does not.

$ docker run --rm --entrypoint /bin/bash apache/polaris:postgres-latest -c "find /deployments/ -name '*.jar' | grep postgres"
/deployments/lib/main/org.postgresql.postgresql-42.7.5.jar
$ docker run --rm --entrypoint /bin/bash apache/polaris-admin-tool:postgres-latest -c "find /deployments/ -name '*.jar' | grep postgres"
$
$

Copy link
Contributor Author

@pingtimeout pingtimeout Apr 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have opened #1447 to fix the build. Closing this PR as it is not the right solution.

-Dquarkus.container-image.tag=postgres-latest \
-Dquarkus.container-image.build=true
```
Expand Down