Skip to content

Update .asf.yaml adding dismiss_stale_reviews to true and require_last_push_approval to false #1265

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 30, 2025
Merged

Update .asf.yaml adding dismiss_stale_reviews to true and require_last_push_approval to false #1265

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .asf.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,8 @@ github:
main:
required_pull_request_reviews:
require_code_owner_reviews: false
dismiss_stale_reviews: true
Copy link
Contributor

@dimas-b dimas-b Mar 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry, @jbonofre , I could not find any description for this option in the README linked from the PR 😅 Could you add a comment to explain how it works?

Copy link
Member Author

@jbonofre jbonofre Mar 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The documentation is light here, I agree 😄 (https://github.com/apache/infrastructure-asfyaml/blob/main/README.md?plain=1#L388).

It basically corresponds to this GitHub configuration:

Copy link
Contributor

@dimas-b dimas-b Mar 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx!

Copy link
Contributor

@dimas-b dimas-b Mar 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So, IIUC, dismiss_stale_reviews will automatically dismiss approvals and "request changes" when new commits are added?

Copy link
Contributor

@eric-maynard eric-maynard Mar 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree that's a little awkward... but we already have the option to manually do that dismissal, so automating it doesn't really move the needle too much imo.

Copy link
Member Author

@jbonofre jbonofre Mar 30, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

An approval will be needed as soon as a PR is updated (not stale anymore). I propose to merge and try 😄 If it's worse than before, I will revert.

require_last_push_approval: false
required_approving_review_count: 1

required_linear_history: true
Expand Down