Skip to content

Let PurgeCommand inspect the results #1226

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 22, 2025
Merged

Let PurgeCommand inspect the results #1226

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 21 additions & 3 deletions quarkus/admin/src/main/java/org/apache/polaris/admintool/PurgeCommand.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@
package org.apache.polaris.admintool;

import java.util.List;
import java.util.Map;
import picocli.CommandLine;

@CommandLine.Command(
Expand All @@ -37,9 +38,26 @@ public class PurgeCommand extends BaseCommand {
@Override
public Integer call() {
try {
metaStoreManagerFactory.purgeRealms(realms);
spec.commandLine().getOut().println("Purge completed successfully.");
return 0;
var result = metaStoreManagerFactory.purgeRealms(realms);
var failed =
result.entrySet().stream()
.filter(e -> !e.getValue().isSuccess())
.map(Map.Entry::getKey)
.toList();
if (failed.isEmpty()) {
spec.commandLine().getOut().println("Purge completed successfully.");
return 0;
}

var out = spec.commandLine().getOut();
Copy link
Contributor

@eric-maynard eric-maynard Mar 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be inlined or pulled above line 47

Copy link
Member Author

@snazy snazy Mar 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rather a nit, right?

failed.forEach(
r ->
out.printf(
"Realm %s is not bootstrapped, could not load root principal. Please run Bootstrap command.%n",
r));

spec.commandLine().getErr().printf("Purge encountered errors during operation.");
return EXIT_CODE_PURGE_ERROR;
} catch (Exception e) {
spec.commandLine().getErr().println("Purge encountered errors during operation.");
return EXIT_CODE_PURGE_ERROR;
Expand Down