Skip to content

Use 'en-us' in all Dockerfiles, Gradle Test tasks and Quarkus defaults #1214

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 20, 2025
Merged

Use 'en-us' in all Dockerfiles, Gradle Test tasks and Quarkus defaults #1214

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion build-logic/src/main/kotlin/polaris-java.gradle.kts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -137,7 +137,14 @@ dependencies {
)
}

tasks.withType(Jar::class).configureEach {
tasks.withType<Test>().configureEach {
systemProperty("file.encoding", "UTF-8")
systemProperty("user.language", "en")
systemProperty("user.country", "US")
systemProperty("user.variant", "")
}

tasks.withType<Jar>().configureEach {
manifest {
attributes(
// Do not add any (more or less) dynamic information to jars, because that makes Gradle's
Expand Down
2 changes: 2 additions & 0 deletions getting-started/spark/notebooks/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,8 @@

FROM jupyter/all-spark-notebook:spark-3.5.0

ENV LANGUAGE='en_US:en'
Copy link
Contributor

@eric-maynard eric-maynard Mar 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we actually use this anywhere?

Copy link
Member Author

@snazy snazy Mar 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure - but it doesn't hurt.


COPY --chown=jovyan client /home/jovyan/client
COPY --chown=jovyan regtests/requirements.txt /tmp
RUN pip install -r /tmp/requirements.txt && \
Expand Down
4 changes: 4 additions & 0 deletions quarkus/defaults/src/main/resources/application.properties
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -159,3 +159,7 @@ quarkus.index-dependency.guava.group-id=com.google.guava
quarkus.index-dependency.guava.artifact-id=guava
quarkus.index-dependency.protobuf.group-id=com.google.protobuf
quarkus.index-dependency.protobuf.artifact-id=protobuf-java

# force the locale, just in case the system's using another default locale
quarkus.default-locale=en_US

1 change: 1 addition & 0 deletions regtests/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@ FROM docker.io/apache/spark:3.5.5-java17-python3
ARG POLARIS_HOST=polaris
ENV POLARIS_HOST=$POLARIS_HOST
ENV SPARK_HOME=/opt/spark
ENV LANGUAGE='en_US:en'

USER root
RUN apt update
Expand Down
2 changes: 2 additions & 0 deletions site/docker/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,8 @@

FROM ubuntu:24.04 AS hugo

ENV LANGUAGE='en_US:en'

RUN apt-get update
RUN apt-get install --yes golang hugo asciidoctor npm curl
RUN apt-get clean
Expand Down