Skip to content

Add missing changes for eclipselink #118

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Add missing changes for eclipselink #118

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9d48b8a
Add missing changes for eclipselink
MonkeyCanCode Aug 8, 2024
83fe3e8
Keep default metastore in-memory
MonkeyCanCode Aug 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions extension/persistence/eclipselink/build.gradle.kts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@ dependencies {
implementation(libs.eclipselink)
implementation(platform(libs.dropwizard.bom))
implementation("io.dropwizard:dropwizard-jackson")
implementation(libs.h2) // Different dependencies will be needed for different backend databases
compileOnly(libs.jetbrains.annotations)

testImplementation(libs.h2)
Expand Down
2 changes: 1 addition & 1 deletion polaris-server.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,7 +90,7 @@ defaultRealms:
metaStoreManager:
type: in-memory
# type: eclipse-link # uncomment to use eclipse-link as metastore
# persistence-unit: polaris
Copy link
Contributor

@sfc-gh-aixu sfc-gh-aixu Aug 8, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I intentionally keep this to be polaris rather than polaris-dev. polaris-dev is used in test and polaris is used for production.

Copy link
Contributor

@sfc-gh-aixu sfc-gh-aixu Aug 8, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise, if we have persistence.xml from test resource and production resource, we are loading the one from test resource.

Copy link
Contributor Author

@MonkeyCanCode MonkeyCanCode Aug 8, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got it. Let me revert this one...but I don't think we will need this PR as the change is intensional based off https://github.com/polaris-catalog/polaris/pull/114/files. I think the only thing that is missing there is h2 lib import. Let me close this one and use 114 to add that in.

Copy link
Contributor Author

@MonkeyCanCode MonkeyCanCode Aug 8, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@collado-mike close this one and added comment in your PR for including h2 lib if people ant to use default persist backend with h2.

# persistence-unit: polaris-dev


# TODO - avoid duplicating token broker config
Expand Down
1 change: 1 addition & 0 deletions polaris-service/build.gradle.kts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@ plugins {

dependencies {
implementation(project(":polaris-core"))
implementation(project(":polaris-eclipselink"))

implementation(platform(libs.iceberg.bom))
implementation("org.apache.iceberg:iceberg-api")
Expand Down