Use Caffeine's Expiry.creating for StorageCredentialCache
#1142
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smaheshwar-pltr
force-pushed
the
sreesh/other
branch
from
7429b3a to
3eeab0a
Compare
smaheshwar-pltr
changed the title
smaheshwar-pltr
changed the title
Expiry.writing for StorageCredentialCache
smaheshwar-pltr
commented
Mar 10, 2025
polaris-core/src/main/java/org/apache/polaris/core/storage/cache/StorageCredentialCache.java
Outdated
Show resolved
Hide resolved
smaheshwar-pltr
requested review from
MonkeyCanCode,
RussellSpitzer,
adutra,
ashvina,
collado-mike,
dennishuo,
dimas-b,
ebyhr,
eric-maynard,
flyrain,
jackye1995,
jbonofre,
snazy,
takidau and
vvcephei
as code owners
smaheshwar-pltr
changed the title
Expiry.writing for StorageCredentialCacheExpiry.creating for StorageCredentialCache
dimas-b
approved these changes
Mar 12, 2025
Contributor
dimas-b
left a comment
dimas-b
left a comment
There was a problem hiding this comment.
Thanks for your contribution @smaheshwar-pltr !
This is a nice code clarification 👍
github-project-automation
bot
moved this from PRs In Progress
to Ready to merge
in Basic Kanban Board
Contributor
|
@collado-mike @eric-maynard WDYT? |
eric-maynard
approved these changes
Mar 12, 2025
github-project-automation
bot
moved this from Ready to merge
to Done
in Basic Kanban Board
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
StorageCredentialCachecurrently uses a customExpiry. I think that this works correctly.IMHO using a built-in one that Caffeine provides, like
Expiry.writingreads better - this is what this PR proposes.