Add Identifier annotation to DefaultActiveRolesProvider #1111
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eric-maynard
requested review from
adutra,
ashvina,
dennishuo,
dimas-b and
jackye1995
as code owners
eric-maynard
requested review from
MonkeyCanCode,
RussellSpitzer,
collado-mike,
ebyhr,
flyrain,
jbonofre,
snazy,
takidau and
vvcephei
as code owners
dimas-b
approved these changes
Mar 5, 2025
Contributor
dimas-b
left a comment
dimas-b
left a comment
There was a problem hiding this comment.
This change is innocuous in the current codebase. The added identifier could be used to look up an ActiveRolesProvider by custom producers in environments where multiple implementations are available.
github-project-automation
bot
moved this from PRs In Progress
to Ready to merge
in Basic Kanban Board
Contributor
|
My mistake, as CI shows the change is not innoccuous 😅 This can be resolved by adding a custom producer method similar to this: |
dimas-b
reviewed
Mar 5, 2025
|
|
||
| @Produces | ||
| public ActiveRolesProvider activeRolesProvider( | ||
| @ConfigProperty(name = "quarkus.active-roles-provider.type") String persistenceType, |
Contributor
There was a problem hiding this comment.
We probably need to set this config in application.properties to default
Contributor
Author
Contributor
This is usually an indicator that the server did not start for some reason... The root cause may be hidden in logs (especially if they are redirected). |
github-project-automation
bot
moved this from Ready to merge
to Done
in Basic Kanban Board
eric-maynard
added a commit
to eric-maynard/polaris
that referenced
this pull request
Mar 13, 2025
…apache#24) * add identifier * add producer * add to config Co-authored-by: Eric Maynard <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When debugging with Quarkus, @RichardLiu2001 and I noticed that
DefaultActiveRolesProviderdoesn't have anIdentifiercurrently. This means that if we add a new implementation ofActiveRolesProvider, the runtime can fail with: