Skip to content

build-logic: let javadoc depend on jandex #1034

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 25, 2025
Merged

build-logic: let javadoc depend on jandex #1034

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions build-logic/src/main/kotlin/polaris-java.gradle.kts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -204,6 +204,9 @@ tasks.withType<Javadoc>().configureEach {
val opt = options as CoreJavadocOptions
// don't spam log w/ "warning: no @param/@return"
opt.addStringOption("Xdoclint:-reference", "-quiet")
if (plugins.hasPlugin("org.kordamp.gradle.jandex")) {
dependsOn("jandex")
Copy link
Contributor

@dimas-b dimas-b Feb 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why does javadoc have to depend on jandex? Should it not be the task that packages the jar?

Copy link
Member Author

@snazy snazy Feb 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Jandex writes to resources, which is "consumed" by javadoc

Copy link
Contributor

@dimas-b dimas-b Feb 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TIL 👍

}
}

tasks.register("printRuntimeClasspath").configure {
Expand Down