[BUG]Pagination is not working for List namespaces

[shraddhagrawal]

Is this a possible security vulnerability?

• This is NOT a possible security vulnerability

Describe the bug

Even if we specify page size api is returning all namespaces
In docs it is mentioned "servers that support pagination" can you please elaborate what this means?

To Reproduce

curl --location 'http://localhost:8181/api/catalog/v1/polaris/namespaces?parent=accounting&pageSize=1&pageToken=null'
--header 'Authorization: Bearer principal:root;password:xxxxxxxxxxxxxxxx;realm:default-realm;role:ALL'
--data ''

Actual Behavior

returned all namespaces

Expected Behavior

return only one namespace

Additional context

No response

System information

No response

[ebyhr]

Polaris doesn't support pagination yet in my understanding. You can see pageToken and pageSize parameters are unused:

https://github.com/polaris-catalog/polaris/blob/167f71bf9ce33cb9cda24c8ebb8a8a00bd19a367/polaris-service/src/main/java/io/polaris/service/catalog/IcebergCatalogAdapter.java#L117-L128

[adam-christian-software]

@dimas-b, @snazy , & @eric-maynard - I was going through older bugs and I saw that this might be coming for 1.1.0? Is that correct?

[dimas-b]

List namespace pagination is supported in Polaris 1.1.0 (upcoming release), but it's not enabled by default.

Setting the LIST_PAGINATION_ENABLED feature flag to true enables it.

For example, using 1.1.0 RC0:

$ env POLARIS_BOOTSTRAP_CREDENTIALS=POLARIS,pol123,pol123s POLARIS_JAVA_OPTS="-Dpolaris.features.LIST_PAGINATION_ENABLED=true" bin/server

In Spark:

$ bin/spark-sql \
         --packages org.apache.iceberg:iceberg-spark-runtime-3.5_2.12:1.9.0,org.apache.iceberg:iceberg-aws-bundle:1.9.0 \
         --conf spark.sql.extensions=org.apache.iceberg.spark.extensions.IcebergSparkSessionExtensions \
         --conf spark.sql.catalog.polaris=org.apache.iceberg.spark.SparkCatalog \
         --conf spark.sql.catalog.polaris.type=rest \
         --conf spark.sql.catalog.polaris.uri=http://localhost:8181/api/catalog \
         --conf spark.sql.catalog.polaris.token-refresh-enabled=false \
         --conf spark.sql.catalog.polaris.warehouse=polaris \
         --conf spark.sql.catalog.polaris.scope=PRINCIPAL_ROLE:ALL \
         --conf spark.sql.catalog.polaris.header.X-Iceberg-Access-Delegation=vended-credentials \
         --conf spark.sql.catalog.polaris.credential=pol123:pol123s

[...]
spark-sql ()> create namespace ns1;
Time taken: 0.349 seconds
spark-sql ()> create namespace ns2;
Time taken: 0.038 seconds
spark-sql ()> create namespace ns3;
Time taken: 0.034 seconds

In curl:

$ curl -H "Authorization: Bearer $POLARIS_TOKEN" -X GET 'http://localhost:8181/api/catalog/v1/polaris/namespaces'
{"namespaces":[["ns1"],["ns2"],["ns3"]],"next-page-token":null}
$ curl -H "Authorization: Bearer $POLARIS_TOKEN" -X GET 'http://localhost:8181/api/catalog/v1/polaris/namespaces?pageSize=1'
{"namespaces":[["ns1"]],"next-page-token":"OikKAfqAcMKAdvqAdEBlgGnK-_s="}
$ curl -H "Authorization: Bearer $POLARIS_TOKEN" -X GET 'http://localhost:8181/api/catalog/v1/polaris/namespaces?pageSize=1&pageToken=OikKAfqAcMKAdvqAdEBlgGnK-_s='
{"namespaces":[["ns2"]],"next-page-token":"OikKAfqAcMKAdvqAdEBlgGnM-_s="}