-
Notifications
You must be signed in to change notification settings - Fork 2.8k
Fix JavadocParagraph
#2302
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix JavadocParagraph
#2302
Conversation
[INFO] BUILD SUCCESS |
827b1dd
to
1252c1d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you're using a tool, add it to the PR.
If you want to enforce a checkstyle rule, you need to enabled it.
In this very case, I have a hard time to see what it fixes, and what good it brings. This additional empty lines helps readability of the doc imho.
Modernize codebase - fix JavadocParagraph
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This hinders readability.
To keep readability, maybe put <p>
on its own line.
Also, if you want to enforce checkstyle rules, this need to be done in the checkstyle config.
yes.
yes, where are the rules please? Maybe here? |
should add rule via checkstyle and then only make ci happy. |
1252c1d
to
e58f596
Compare
s&r = error before: Files changed 135 ide fix = save after: Files changed 49 |
less then 50 might be acceptable. |
Fix
JavadocParagraph
enabler for
JavadocParagraph
maven-shared-resources#72refs:
DefaultModelProcessor#read
#2292tryout: