[#215] Test for multi release jar sources #234
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bmarwell
force-pushed
the
MSOURCES-144_include_additional_source_roots
branch
2 times, most recently
from
06e39c1 to
a7e94ad
Compare
bmarwell
force-pushed
the
MSOURCES-144_include_additional_source_roots
branch
4 times, most recently
from
eb6c3f9 to
b8c672b
Compare
Refs: apache#215, MSOURCES-144
bmarwell
force-pushed
the
MSOURCES-144_include_additional_source_roots
branch
from
b8c672b to
e5fe279
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs: #215, MSOURCES-144
This test will currently fail. At the moment, there is an oversight mentioned in #215 by Tagir: For Multi-Release jars, the additional source folders (specified in the compiler plugin) are not detected and not included into the source archive.
Also, the source archive does not have a "correct" place where to put them, as of now. I am assuming
META-INF/versions/${javaversion}/for the moment.