-
Notifications
You must be signed in to change notification settings - Fork 142
Demote JDK transport #1599
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Demote JDK transport #1599
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Originally we have this order of transports w/ priorities (present/absent in maven core):
* wagon -1.0 (present)
* apache 5.0 (present)
* jdk 10.0 (present) ("default" transport)
* jetty 15.p (absent) (if user added it via extension or lib/ext it "wins")
But lately we see that JDK one advantage of HTTP/2 support (that is
already disabled due various issues) is shaded due several
disadvantages (no support for HTTPS proxies, unstable, and unreliable)
Hence, I propose to "demote" it (maybe even remove it from Maven core):
* wagon -1.0 (present)
* jdk 5.0 (present; and maybe remove it from maven core)
* apache 10.0 (present; new "default" transport)
* jetty 15.0 (absent)
This makes Maven 4 not have "modern" HTTP transport by default, but
apache transport is well battle tested and robust, with one issue:
lack of HTTP/2 support (that does improve download speeds).
gnodet
approved these changes
Sep 22, 2025
cstamas
added a commit
to cstamas/maven-resolver
that referenced
this pull request
Oct 1, 2025
This reverts commit 2ca95ee.
cstamas
added a commit
that referenced
this pull request
Oct 7, 2025
|
Should it be reconsidered since at least some of the issues are addressed according this discussion? |
Member
Author
|
Just FYI, and sorry for the confusion, It was me hastily "demoting" but
then after change in mind doing this:
#1611
So, mvn4-rc-5 did NOT demote JDK transport after all.
Still, this will not reduce deps as Martin writes, as HttpClient transport
is still present in Maven (in fact, HttpClient is a requirement of Wagon,
that in turn, is needed to provide Maven 3 backward compat).
We may drop all these only in Maven 5 I guess.
T
…On Fri, Nov 14, 2025 at 2:09 PM Martin Desruisseaux < ***@***.***> wrote:
*desruisseaux* left a comment (apache/maven-resolver#1599)
<#1599 (comment)>
Should it be reconsidered since at least some of the issues are addressed
according this discussion
<https://lists.apache.org/thread/d0dc23pk5srsch5hx9kg6tkyjnl7tpxq>?
—
Reply to this email directly, view it on GitHub
<#1599 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAALA3IEY74KQ54GVDUAPUD34XIAHAVCNFSM6AAAAACHFG6OICVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTKMZSGY2TKNZYGU>
.
You are receiving this because you modified the open/close state.Message
ID: ***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Originally we have this order of transports w/ priorities (present/absent in maven core):
But lately we see that JDK one advantage of HTTP/2 support (that is already disabled due various issues) is shaded due several disadvantages (no support for HTTPS proxies, unstable, and unreliable)
Hence, I propose to "demote" it (maybe even remove it from Maven core):
This makes Maven 4 not have "modern" HTTP transport by default, but apache transport is well battle tested and robust, with one issue: lack of HTTP/2 support (that does improve download speeds).
If we decide for this, it will have impact on Maven ITs as well that asser default transport.