[MRESOLVER-8] ScopeDependencySelector incorrectly de-selects direct dependencies

[jira-importer]

Christian Schulte opened MRESOLVER-8 and commented

The ScopeDependencySelector decides if a node is a direct dependency or transitive dependency differently based on the request performed. For the CollectRequest.setRootArtifact(Artifact) case, the class is working correctly. For the CollectRequest.setRoot(Dependency) case, the class is de-selecting direct dependencies instead of transitive dependencies.

---

Issue Links:

• MNG-6135 Maven plugins and core extensions are not dependencies, they should be resolved the same way as projects.
  ("blocks")

• MPLUGIN-321 improve documentation on maven-plugin-annotations telling that optional=true is sufficient

• MEAR-246 Upgrade the EAR lifecycle to use the maven-resources-plugin 3.0.2.
  ("breaks")

• MPLUGIN-296 java.lang.ClassNotFoundException: org.apache.maven.plugins.annotations.Execute
  ("breaks")

• MWAR-400 Upgrade the WAR lifecycle to use the maven-resources-plugin 3.0.2
  ("breaks")

• MRESOURCES-234 Upgrade of commons-io to 2.5 and correction of invalid scope.
  ("breaks")

• MPMD-230 Required class missing: org/apache/commons/io/IOUtils
  ("breaks")

• MRESOLVER-12 Addition of unit tests for DependencySelector implementations
  ("is depended upon by")

Remote Links:

• GitHub Pull Request #107
  

[jira-importer]

Christian Schulte commented

Re-opening to edit description.

[jira-importer]

Christian Schulte commented

Issue is fixed in the master branch of my private maven repository on github. When interested, you can cherry pick the commit to your own repository and create a pull request for the apache master branch with just this commit yourself from there.

[jira-importer]

Michael Osipov commented

The following ITs are broken for now:

[ERROR] Failures:
[ERROR]   MavenITmng5783PluginDependencyFiltering>AbstractMavenIntegrationTestCase.runTest:222->testSLF4j:34 expected:<3> but was:<2>
[ERROR] Errors:
[ERROR]   MavenITmng3599useHttpProxyForWebDAVMk2Test>AbstractMavenIntegrationTestCase.runTest:222->testitUseHttpProxyForWebDAV:204 » Verification
[ERROR]   MavenITmng5771CoreExtensionsTest>AbstractMavenIntegrationTestCase.runTest:222->testCoreExtensionRetrievedFromAMirrorWithBasicAuthentication:85 » Verification

[jira-importer]

Michael Osipov commented

I have rebased this branch and applied MNG-6135 to Maven, still a lot of tests are failing. W/o knowing which issues need to merged to make this work, this is hardly ever be merged.