-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Update documentation #788
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Update documentation #788
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
df492f3
Update documentation as mentioned in https://issues.apache.org/jira/b…
phreed 03d34df
corrected typo in builder method name 'withtFilter' -> 'withFilter'
phreed 387d655
corrected typo in builder method name 'withtFilter' -> 'withFilter'
phreed bb62e8c
corrected typo in builder methods named 'withtFilter' -> 'withFilter'
phreed File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have mixed feelings about this change: yes, it would be nice to have a correctly spelled method, but the other one was already released and it is API.
Don't change the name of the method, deprecate it and add another one with the correct spelling.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I deprecated the misspelled method and created a new one with the correct spelling as suggested.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There were two such cases.
What is the rule for naming methods?
When should the name be
setFilter
and whenwithFilter
?I just noticed that the appender was changed from
withFilter
tosetFilter
.Should the same be done here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just add a new method with the correct name and deprecate the bogus one. Simple ;-)