Reopen log file when rollover is unsuccessful (#3226) #3859
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes `RollingFileManager` to reopen the log file when the rollover was unsuccessful
jvz
added
bug
|
@jvz, |
vy
requested changes
Jul 31, 2025
There was a problem hiding this comment.
This changelog entry is not needed, please remove.
|
I had tried a plain cherry-pick for this PR from 2.x. It seems as though it doesn't apply cleanly here. May need to be rewritten. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes
RollingFileManagerto reopen the log file when the rollover was unsuccessfulPort of #3226.