fix: Disable sharing of formatted timestamps between threads #3802
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change disables the sharing of formatted timestamps between threads in `InstantPatternThreadLocalCachedFormatter`.
Previously, a mutable `StringBuilder` was shared across threads via a cached object. This could lead to situations where one thread ("owner") was modifying the builder while another thread was reading from it, resulting in inaccurate or truncated timestamps.
This fix ensures that only thread-local instances are used, preventing concurrency issues and improving timestamp correctness under load.
This change is similar in nature to #1485 and fixes #3792.
vy
reviewed
Jul 4, 2025
...e/logging/log4j/core/util/internal/instant/InstantPatternThreadLocalCachedFormatterTest.java
Show resolved
Hide resolved
vy
approved these changes
Jul 4, 2025
ppkarwasz
added a commit
that referenced
this pull request
Jul 5, 2025
This change disables the sharing of formatted timestamps between threads in `InstantPatternThreadLocalCachedFormatter`.
Previously, a mutable `StringBuilder` was shared across threads via a cached object. This could lead to situations where one thread ("owner") was modifying the builder while another thread was reading from it, resulting in inaccurate or truncated timestamps.
This fix ensures that only thread-local instances are used, preventing concurrency issues and improving timestamp correctness under load.
This change is similar in nature to #1485 and fixes #3792.
vy
pushed a commit
to ashr123/logging-log4j2
that referenced
this pull request
Jul 20, 2025
…3802) This change disables the sharing of formatted timestamps between threads in `InstantPatternThreadLocalCachedFormatter`. Previously, a mutable `StringBuilder` was shared across threads via a cached object. This could lead to situations where one thread ("owner") was modifying the builder while another thread was reading from it, resulting in inaccurate or truncated timestamps. This fix ensures that only thread-local instances are used, preventing concurrency issues and improving timestamp correctness under load. This change is similar in nature to apache#1485 and fixes apache#3792.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change disables the sharing of formatted timestamps between threads in
InstantPatternThreadLocalCachedFormatter.Previously, a mutable
StringBuilderwas shared across threads via a cached object. This could lead to situations where one thread ("owner") was modifying the builder while another thread was reading from it, resulting in inaccurate or truncated timestamps.This fix ensures that only thread-local instances are used, preventing concurrency issues and improving timestamp correctness under load.
This change is similar in nature to #1485 and fixes #3792.