-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Have org.apache.logging.log4j.util.Base64Util invoke java.util.Base64… #3689
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
ppkarwasz
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
Thanks! This pull request will be merged as soon as the required checks pass. |
Head branch was pushed to by a user without write access
… directly instead of reflectively (apache#3686)
|
@ppkarwasz, I'm afraid that by squashing my commits, the signature disappeared ... Should I create a new PR? |
@ppkarwasz, recreated the PR at #3690, confirming it is properly signed. Closing this PR |
In general we prefer to use the same PR. Missing signatures can be corrected via a forced push that replaces all the commits: git rebase --force-rebase --gpg-sign origin/2.x
git push --force |
Thanks, @ppkarwasz - that's good to know! |
… directly instead of reflectively (#3686)
This pull request fixes issue #3686 by having
org.apache.logging.log4j.util.Base64Utilinvokejava.util.Base64directly instead of reflectively. This avoids the need to usejavax.xml.bind.DataTypeConverteras a fallback, which has been problematic because it is not Jakarta EE9 compliant.Checklist
2.xbranch if you are targeting Log4j 2; usemainotherwise./mvnw verifysucceeds (if it fails due to code formatting issues reported by Spotless, simply run./mvnw spotless:applyand retry)src/changelog/.2.x.xdirectory