-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Enable docker
profile in CI for log4j-layout-template-json-test
#2952
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
I am wondering about a couple of things:
|
Bootstrapping an ELK stack is a pretty resource intensive process, I doubt if it will succeed without an OOM on every developer machine. Hence, I am happy with the current setup.
I don't think we should, but I will update the review kit to reflect on the
Addressed this issue. |
Co-authored-by: Piotr P. Karwasz <[email protected]>
FYI: I added: <settings xmlns="http://maven.apache.org/SETTINGS/1.0.0"
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
xsi:schemaLocation="
http://maven.apache.org/SETTINGS/1.0.0
https://maven.apache.org/xsd/settings-1.0.0.xsd">
<!-- Enable Docker profiles in Log4j tests -->
<activeProfiles>
<activeProfile>docker</activeProfile>
</activeProfiles>
</settings> We can add it to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
See #2953 for the
2.x
port.