Move production code to log4j-async-logger
#2248
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A couple more tests require changes to be independent from async loggers and logger configurations. The `CoreContextSelectors` class is not used, so we remove it.
This moves the main code for `AsyncLogger` and `AsyncLoggerConfig` to `log4j-async-logger`. Further tasks such as proper encapsulation into internal packages and removal of the optional dependency guards, will be performed in a future task.
ppkarwasz
commented
Jan 25, 2024
| @Tag("async") | ||
| @UsingStatusListener | ||
| @Timeout(value = 5, unit = SECONDS, threadMode = ThreadMode.SEPARATE_THREAD) | ||
| public abstract class QueueFullAbstractTest { |
There was a problem hiding this comment.
This class has been split in two: QueueFullAbstractTest for the async appender part and QueueFullAsyncAbstractTest.
3 tasks
rgoers
approved these changes
Jan 25, 2024
vy
approved these changes
Jan 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR move the main classes linked with
AsyncLogger,AsyncLoggerConfigandAsyncLoggerContextSelectorto thelog4j-async-loggerartifact.It also removes the dependency on LMAX Disruptor from
log4j-core.Part of #2163.