Remove instance of checks for async components #2242
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
vy
reviewed
Jan 25, 2024
log4j-core/src/main/java/org/apache/logging/log4j/core/config/LoggerConfig.java
Outdated
Show resolved
Hide resolved
log4j-core/src/main/java/org/apache/logging/log4j/core/config/LoggerConfig.java
Outdated
Show resolved
Hide resolved
This PR removes all occurences of `instanceof Async*` that might prevent the separation of the async support. The removal requires a couple of new API methods and binary incompatible changes.
ppkarwasz
force-pushed
the
remove-instanceof-async
branch
from
eb7ed67 to
e6f468a
Compare
vy
approved these changes
Jan 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes all occurences of
instanceof Async*that might prevent the separation of the async support.The removal requires a couple of new API methods and binary incompatible changes.