Add general ConfigurationExtension mechanism
#2230
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ppkarwasz
force-pushed
the
split-async2
branch
2 times, most recently
from
c878ff2 to
e7b386a
Compare
vy
requested changes
Jan 24, 2024
log4j-core/src/main/java/org/apache/logging/log4j/core/config/AbstractConfiguration.java
Outdated
Show resolved
Hide resolved
log4j-core/src/main/java/org/apache/logging/log4j/core/config/ConfigurationExtension.java
Outdated
Show resolved
Hide resolved
log4j-core/src/main/java/org/apache/logging/log4j/core/config/Configuration.java
Show resolved
Hide resolved
log4j-core/src/main/java/org/apache/logging/log4j/core/config/AbstractConfiguration.java
Outdated
Show resolved
Hide resolved
log4j-core/src/main/java/org/apache/logging/log4j/core/config/AbstractConfiguration.java
Outdated
Show resolved
Hide resolved
log4j-core/src/main/java/org/apache/logging/log4j/core/async/DisruptorConfiguration.java
Outdated
Show resolved
Hide resolved
log4j-core/src/main/java/org/apache/logging/log4j/core/async/DisruptorConfiguration.java
Outdated
Show resolved
Hide resolved
ppkarwasz
added a commit
to ppkarwasz/logging-log4j2
that referenced
this pull request
Jan 24, 2024
ppkarwasz
added a commit
to ppkarwasz/logging-log4j2
that referenced
this pull request
Jan 24, 2024
ppkarwasz
force-pushed
the
split-async2
branch
from
d751752 to
031e59a
Compare
vy
approved these changes
Jan 24, 2024
We introduce a general `ConfigurationExtension` mechanism that would allow external Log4j plugins to add additional elements as children of the `<Configuration>` element. This mechanism is used to remove all direct references to async components in `AbstractConfiguration`. The `<AsyncWaitStrategyFactory>` configuration element is renamed to `<Disruptor>`, while maintaining backward compatibility.
ppkarwasz
force-pushed
the
split-async2
branch
from
031e59a to
709c593
Compare
|
Part of #2163 |
|
Do you have some suggestions on the naming of the new |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is based on #2228.
We introduce a general
ConfigurationExtensionmechanism that would allow external Log4j plugins to add additional elements as children of the<Configuration>element.This mechanism is used to remove all direct references to async components in
AbstractConfiguration.The
<AsyncWaitStrategyFactory>configuration element is renamed to<Disruptor>, while maintaining backward compatibility.