Revamp the explanation on creating loggers #79
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ppkarwasz
approved these changes
Jul 5, 2024
There was a problem hiding this comment.
I am not sure if the instance logger vs static logger dispute has a definitive answer.
Instance loggers can use different logger contexts per instance, but their efficacity decreases if there are both instance loggers and static loggers in the application.
So unfortunately static loggers might be the right choice, unless you are writing a multi-application runtime environment and you know what you are doing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tipped by @breun, users find it confusing which logger creation mechanism to choose from. This PR is improves the documentation in that direction.