Skip to content

Conversation

rocketraman
Copy link
Member

Fixes #54

@rocketraman rocketraman requested a review from jvz December 6, 2023 20:20
@jvz
Copy link
Member

jvz commented Dec 6, 2023

@rocketraman can you sign your commits? You can use GPG, SSH, or SMIME for that (I use all three in various places).

@rocketraman
Copy link
Member Author

rocketraman commented Dec 6, 2023

@rocketraman can you sign your commits? You can use GPG, SSH, or SMIME for that (I use all three in various places).

Yep. Do you want me to rebase this PR with a signed commit, or for the future only? Never mind, done.

@rocketraman rocketraman merged commit 6e30c88 into apache:main Dec 6, 2023
@rocketraman
Copy link
Member Author

@jvz Is it possible to release a 1.3.1 with this change? I'm using it in a project which extensively uses logging contexts, and without this change, things are royally messed up.

@jvz
Copy link
Member

jvz commented Dec 6, 2023

@jvz Is it possible to release a 1.3.1 with this change? I'm using it in a project which extensively uses logging contexts, and without this change, things are royally messed up.

Absolutely! Releases are mostly automated at this point, so let's go find out.

@jvz
Copy link
Member

jvz commented Dec 6, 2023

@rocketraman check this out https://logging.apache.org/logging-parent/latest/#release-instructions and see if you can start the release.

@rocketraman rocketraman deleted the issue-54 branch December 6, 2023 23:59
@rocketraman
Copy link
Member Author

rocketraman commented Dec 7, 2023

@rocketraman check this out https://logging.apache.org/logging-parent/latest/#release-instructions and see if you can start the release.

@jvz If I want to do a 1.3.1 release, what is the recommended approach in terms of branches? Create branch release/1.3.1 of off tag rel/1.3.0 and cherry-pick my change into it?

@ppkarwasz
Copy link
Contributor

@rocketraman,

Build #60 failed due to a missing project.build.outputTimestamp property. You should add something like this to the main POM's <properties>:

    <!-- Fixed `project.build.outputTimestamp` is required for reproducible builds: https://maven.apache.org/guides/mini/guide-reproducible-builds.html -->
    <project.build.outputTimestamp>1676697577</project.build.outputTimestamp>

The value of the property does not matter, since the CI should replace it anyway.

If you find other problems in the build or build instructions, please report them to logging-parent.

@vy vy added this to the 13.0.1 milestone Dec 7, 2023
@vy vy assigned vy and rocketraman and unassigned vy Dec 7, 2023
@vy vy added the bug label Dec 7, 2023
@ppkarwasz ppkarwasz modified the milestones: 1.3.1, 1.4.0 Dec 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Coroutine context is not cleared properly
4 participants