[KUBERNETES] Prefer to use pod spark-app-name label as application name than pod name
#7034
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #7034 +/- ##
======================================
Coverage 0.00% 0.00%
======================================
Files 695 695
Lines 42810 42814 +4
Branches 5829 5829
======================================
- Misses 42810 42814 +4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
pan3793
approved these changes
Apr 17, 2025
turboFei
added a commit
that referenced
this pull request
Apr 17, 2025
…as application name than pod name ### Why are the changes needed? After apache/spark#34460 (Since Spark 3.3.0), the `spark-app-name` is available. We shall use it as the application name if it exists. ### How was this patch tested? Minor change. ### Was this patch authored or co-authored using generative AI tooling? No. Closes #7034 from turboFei/k8s_app_name. Closes #7034 bfa88a4 [Wang, Fei] Get pod app name Authored-by: Wang, Fei <[email protected]> Signed-off-by: Wang, Fei <[email protected]> (cherry picked from commit cc68cb4) Signed-off-by: Wang, Fei <[email protected]>
Member
Author
|
thanks, merged to 1.11.0 and 1.10.2 |
turboFei
added a commit
to turboFei/kyuubi
that referenced
this pull request
Apr 24, 2025
…p-name` label as application name than pod name" This reverts commit cc68cb4.
turboFei
added a commit
that referenced
this pull request
Apr 25, 2025
### Why are the changes needed? Followup for #7034 to fix the SparkOnKubernetesTestsSuite. Sorry, I forget that the appInfo name and pod name were deeply bound before, the appInfo name was used as pod name and used to delete pod. In this PR, we add `podName` into applicationInfo to separate app name and pod name. ### How was this patch tested? GA should pass. ### Was this patch authored or co-authored using generative AI tooling? No. Closes #7039 from turboFei/fix_test. Closes #7034 0ff7018 [Wang, Fei] revert 18e48c0 [Wang, Fei] comments 19f34bc [Wang, Fei] do not get pod name from appName c1d3084 [Wang, Fei] reduce interval for test stability 50fad6b [Wang, Fei] fix ut Authored-by: Wang, Fei <[email protected]> Signed-off-by: Wang, Fei <[email protected]>
turboFei
added a commit
that referenced
this pull request
Apr 25, 2025
### Why are the changes needed? Followup for #7034 to fix the SparkOnKubernetesTestsSuite. Sorry, I forget that the appInfo name and pod name were deeply bound before, the appInfo name was used as pod name and used to delete pod. In this PR, we add `podName` into applicationInfo to separate app name and pod name. ### How was this patch tested? GA should pass. ### Was this patch authored or co-authored using generative AI tooling? No. Closes #7039 from turboFei/fix_test. Closes #7034 0ff7018 [Wang, Fei] revert 18e48c0 [Wang, Fei] comments 19f34bc [Wang, Fei] do not get pod name from appName c1d3084 [Wang, Fei] reduce interval for test stability 50fad6b [Wang, Fei] fix ut Authored-by: Wang, Fei <[email protected]> Signed-off-by: Wang, Fei <[email protected]> (cherry picked from commit 75891d1) Signed-off-by: Wang, Fei <[email protected]>
turboFei
added a commit
to turboFei/kyuubi
that referenced
this pull request
Aug 27, 2025
…label as application name than pod name ### Why are the changes needed? After apache/spark#34460 (Since Spark 3.3.0), the `spark-app-name` is available. We shall use it as the application name if it exists. ### How was this patch tested? Minor change. ### Was this patch authored or co-authored using generative AI tooling? No. Closes apache#7034 from turboFei/k8s_app_name. Closes apache#7034 bfa88a4 [Wang, Fei] Get pod app name Authored-by: Wang, Fei <[email protected]> Signed-off-by: Wang, Fei <[email protected]>
turboFei
added a commit
to turboFei/kyuubi
that referenced
this pull request
Aug 27, 2025
…pp name ### Why are the changes needed? Followup for apache#7034 to fix the SparkOnKubernetesTestsSuite. Sorry, I forget that the appInfo name and pod name were deeply bound before, the appInfo name was used as pod name and used to delete pod. In this PR, we add `podName` into applicationInfo to separate app name and pod name. ### How was this patch tested? GA should pass. ### Was this patch authored or co-authored using generative AI tooling? No. Closes apache#7039 from turboFei/fix_test. Closes apache#7034 0ff7018 [Wang, Fei] revert 18e48c0 [Wang, Fei] comments 19f34bc [Wang, Fei] do not get pod name from appName c1d3084 [Wang, Fei] reduce interval for test stability 50fad6b [Wang, Fei] fix ut Authored-by: Wang, Fei <[email protected]> Signed-off-by: Wang, Fei <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are the changes needed?
After apache/spark#34460 (Since Spark 3.3.0), the
spark-app-nameis available.We shall use it as the application name if it exists.
How was this patch tested?
Minor change.
Was this patch authored or co-authored using generative AI tooling?
No.