[K8S][HELM] Set specific Kyuubi version to the chart appVersion #4484
Conversation
| name: kyuubi | ||
| description: A Helm chart for Kyuubi server | ||
| type: application | ||
| version: 0.1.0 |
There was a problem hiding this comment.
question: is there any suggestion/guidance for this version?
There was a problem hiding this comment.
Nothing in particular. Chart version needs to be changed on each chart release. By release I mean creating chart archive and adding it to chart repository.
I would prefer to keep 0.1.0 for the initial dev release, which is much closer now because of the official Kyuubi docker image. Not sure how often the chart should be released. For example MinIO, Argo and many others release it quite frequently (for one or few changes), but Airflow releases helm chart only once for each minor (x.Y.z) application version.
…ppVersion ### _Why are the changes needed?_ The change is needed to use stable released version of Kyuubi instead of night/dev builds by default. ### _How was this patch tested?_ - [ ] Add some test cases that check the changes thoroughly including negative and positive cases if possible - [ ] Add screenshots for manual tests if appropriate - [ ] [Run test](https://kyuubi.readthedocs.io/en/master/develop_tools/testing.html#running-tests) locally before make a pull request Closes #4484 from dnskr/helm_set_specific_release_version. Closes #4484 4c979c6 [dnskr] [K8S][HELM] Set specific Kyuubi version to the chart appVersion Authored-by: dnskr <[email protected]> Signed-off-by: Cheng Pan <[email protected]> (cherry picked from commit 8289523) Signed-off-by: Cheng Pan <[email protected]>
|
Thanks, merged to master/1.7, and also cc @yanghua as you are investigating the kubevela related stuffs. |
sorry for the late reply, thanks! |
3 participants
Why are the changes needed?
The change is needed to use stable released version of Kyuubi instead of night/dev builds by default.
How was this patch tested?
Add some test cases that check the changes thoroughly including negative and positive cases if possible
Add screenshots for manual tests if appropriate
Run test locally before make a pull request