[CI] Store kyuubi-spark-batch-submit.log for IT spark on kubernetes batch test #3728
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pan3793
approved these changes
Oct 31, 2022
3 tasks
Member
|
Thanks, merging to master/1.6 |
pan3793
pushed a commit
that referenced
this pull request
Oct 31, 2022
…on kubernetes batch test Currently, we only store unit-tests.log and kyuubi-spark-sql-engine.log for spark-on-k8s-it ci test. As there are some batch test in spark-on-k8s-it ci , we should also store kyuubi-spark-batch-submit.log for debug. - [ ] Add some test cases that check the changes thoroughly including negative and positive cases if possible - [ ] Add screenshots for manual tests if appropriate - [ ] [Run test](https://kyuubi.apache.org/docs/latest/develop_tools/testing.html#running-tests) locally before make a pull request - [x] Run CI Test Closes #3728 from zwangsheng/ci/storage_batch_engine_log. Closes #3728 502639f [zwangsheng] fixx Authored-by: zwangsheng <[email protected]> Signed-off-by: Cheng Pan <[email protected]> (cherry picked from commit e03fa93) Signed-off-by: Cheng Pan <[email protected]>
github-actions
bot
added
the
kind:infra
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are the changes needed?
Currently, we only store unit-tests.log and kyuubi-spark-sql-engine.log for spark-on-k8s-it ci test.
As there are some batch test in spark-on-k8s-it ci , we should also store kyuubi-spark-batch-submit.log for debug.
How was this patch tested?
Add some test cases that check the changes thoroughly including negative and positive cases if possible
Add screenshots for manual tests if appropriate
Run test locally before make a pull request
Run CI Test