[SPARK][K8S][BATCH] Kyuubi should set env SPARK_USER_NAME on submitting Spark batch job to K8s #3664
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
pan3793
approved these changes
Oct 20, 2022
Codecov Report
@@ Coverage Diff @@
## master #3664 +/- ##
============================================
+ Coverage 52.02% 52.03% +0.01%
Complexity 13 13
============================================
Files 485 485
Lines 27202 27203 +1
Branches 3793 3793
============================================
+ Hits 14151 14155 +4
+ Misses 11685 11679 -6
- Partials 1366 1369 +3
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
pan3793
changed the title
Member
|
Thanks, merging to master/1.6, also cc @cxzl25 |
pan3793
pushed a commit
that referenced
this pull request
Oct 20, 2022
…AME on submitting Spark batch job to K8s ### _Why are the changes needed?_ Batch job should also submit with `SPARK_USER_NAME`. See more in pre pr #3527 . ### _How was this patch tested?_ - [ ] Add some test cases that check the changes thoroughly including negative and positive cases if possible - [ ] Add screenshots for manual tests if appropriate - [x] [Run test](https://kyuubi.apache.org/docs/latest/develop_tools/testing.html#running-tests) locally before make a pull request Closes #3664 from zwangsheng/feature/batch_with_user_name. Closes #3664 76dee3e [zwangsheng] style 0d40508 [zwangsheng] fix a1fcf7f [zwangsheng] fix Authored-by: zwangsheng <[email protected]> Signed-off-by: Cheng Pan <[email protected]> (cherry picked from commit 5f8b57b) Signed-off-by: Cheng Pan <[email protected]>
Contributor
|
+1, late LGTM. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are the changes needed?
Batch job should also submit with
SPARK_USER_NAME.See more in pre pr #3527 .
How was this patch tested?
Add some test cases that check the changes thoroughly including negative and positive cases if possible
Add screenshots for manual tests if appropriate
Run test locally before make a pull request