Skip to content

[KYUUBI #3527][SPARK][FOLLOWUP] spark.kubernetes.executorEnv should be spark.executorEnv #3591

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

[KYUUBI #3527][SPARK][FOLLOWUP] spark.kubernetes.executorEnv should be spark.executorEnv #3591

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion kyuubi-server/src/main/scala/org/apache/kyuubi/engine/spark/SparkProcessBuilder.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,7 +98,7 @@ class SparkProcessBuilder(
buffer += CONF
buffer += s"spark.kubernetes.driverEnv.SPARK_USER_NAME=$userName"
buffer += CONF
buffer += s"spark.kubernetes.executorEnv.SPARK_USER_NAME=$userName"
buffer += s"spark.executorEnv.SPARK_USER_NAME=$userName"
}
})
}
Expand Down
6 changes: 3 additions & 3 deletions kyuubi-server/src/test/scala/org/apache/kyuubi/engine/spark/SparkProcessBuilderSuite.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -277,7 +277,7 @@ class SparkProcessBuilderSuite extends KerberizedTestHelper with MockitoSugar {
val b1 = new SparkProcessBuilder(proxyName, conf1)
val c1 = b1.toString.split(' ')
assert(c1.contains(s"spark.kubernetes.driverEnv.SPARK_USER_NAME=$proxyName"))
assert(c1.contains(s"spark.kubernetes.executorEnv.SPARK_USER_NAME=$proxyName"))
assert(c1.contains(s"spark.executorEnv.SPARK_USER_NAME=$proxyName"))

tryWithSecurityEnabled {
val conf2 = conf.set("spark.master", "k8s://test:12345")
Expand All @@ -287,7 +287,7 @@ class SparkProcessBuilderSuite extends KerberizedTestHelper with MockitoSugar {
val b2 = new SparkProcessBuilder(name, conf2)
val c2 = b2.toString.split(' ')
assert(c2.contains(s"spark.kubernetes.driverEnv.SPARK_USER_NAME=$name"))
assert(c2.contains(s"spark.kubernetes.executorEnv.SPARK_USER_NAME=$name"))
assert(c2.contains(s"spark.executorEnv.SPARK_USER_NAME=$name"))
assert(!c2.contains(s"--proxy-user $name"))
}

Expand All @@ -296,7 +296,7 @@ class SparkProcessBuilderSuite extends KerberizedTestHelper with MockitoSugar {
val b3 = new SparkProcessBuilder(proxyName, conf3)
val c3 = b3.toString.split(' ')
assert(!c3.contains(s"spark.kubernetes.driverEnv.SPARK_USER_NAME=$proxyName"))
assert(!c3.contains(s"spark.kubernetes.executorEnv.SPARK_USER_NAME=$proxyName"))
assert(!c3.contains(s"spark.executorEnv.SPARK_USER_NAME=$proxyName"))
}
}

Expand Down