MINOR: Hint about "docker system prune" when ducker-ak build fails #10995
Conversation
New versions of pip apparently removed support for Python 3.5, the version of Python our ducker image is using. They used to support it, and now they only support newer versions of Python. We will eventually have to upgrade the version of Python in the image. That will probably mean moving to a different Ubuntu base image. However, for now, using pip 20.3.4 seems to work and is easier.
cmccabe
force-pushed
the
fix-python-pip-version-mess
branch
from
dcac06d to
918b4a7
Compare
|
I hit this same problem and was able to resolve it with Maybe we can modify this PR to instead provide a more helpful error message? |
cmccabe
changed the title
| echo_and_do() { | ||
| local cmd="${@}" | ||
| echo "${cmd}" | ||
| ${cmd} |
There was a problem hiding this comment.
The logic through must_do, which we were doing previously also redirects output and checks the command return. Should we do something similar?
There was a problem hiding this comment.
Well... I made this new function because the other one was checking the output and exiting if it was nonzero. That didn't allow me to print the error message I wanted. So doing the same thing here would defeat the point :)
If bash shell was a better language, I could add a lambda argument to the existing function and have the lambda return what to print on failure. But shell doesn't really do closures, so it would turn into kind of a mess.
There was a problem hiding this comment.
Also I guess some people would say that I'm doing things too much the Java way here, and that the kewl bash way of doing this would be
set -x
<run command>
set +x
But it still feels kind of like a mess since, does set +x change $? ?
Sigh.
|
There is also a tip to run the command with |
|
Also, can you update the label from |
|
@kamalcph : Thanks, that is a good find. I agree we should update the label from ducker.type to ducker.creator. Can you make a separate PR for that? I can review it quickly. |
I agree |
…10995) Reviewers: Kamal Chandraprakash <[email protected]>, Jason Gustafson <[email protected]>
…pache#10995) Reviewers: Kamal Chandraprakash <[email protected]>, Jason Gustafson <[email protected]>
4 participants
No description provided.